Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename sentiment to style #2979

Merged
merged 11 commits into from
May 28, 2019
Merged

Rename sentiment to style #2979

merged 11 commits into from
May 28, 2019

Conversation

RebeccaAnne
Copy link
Contributor

@RebeccaAnne RebeccaAnne commented May 24, 2019 •
edited by almedina-ms
Loading

Rename sentiment to style. Currently includes samples, shared model, iOS, UWP, and .NET.

How verified: Run tests for all affected platforms.

Fixes: #2972
Fixes: #2976
Fixes: #2977
Fixes: #2974
Fixes: #2973

Microsoft Reviewers: Open in CodeFlow

shalinijoshi19
shalinijoshi19 approved these changes May 24, 2019
View reviewed changes
Copy link
Member

@shalinijoshi19 shalinijoshi19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@RebeccaAnne
Copy link
Contributor Author

RebeccaAnne commented May 24, 2019 •
edited by jwoo-msft
Loading

@nesalang Do you know why the ios build is still failing? #Resolved

@jwoo-msft
Copy link
Member

Action.ShowCard.Style.json was referred twice.

In reply to: 495773840 [](ancestors = 495773840)

almedina-ms
almedina-ms approved these changes May 28, 2019
View reviewed changes
Copy link
Contributor

@almedina-ms almedina-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@paulcam206
Copy link
Member

paulcam206 commented May 28, 2019 •
edited
Loading

still seeing cards with sentiment under source/android/mobilechatapp/src/main/assets

there are other references to sentiment, but don't appear to be on the API surface, so I'm not sure how much we care... #Closed

paulcam206
paulcam206 requested changes May 28, 2019
View reviewed changes
Copy link
Member

@paulcam206 paulcam206 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@almedina-ms
Copy link
Contributor

if it's the mobilechatapp, do a Rebuild as the cards are sometimes not deleted. source/android/mobilechatapp/src/main/assets should not exist in master as it's just a copy of the samples folder so the cards can be rendered without us copying the samples explicitly to the device

In reply to: 496673644 [](ancestors = 496673644)

@paulcam206
Copy link
Member

ah -- that makes sense... thanks! :)

In reply to: 496707584 [](ancestors = 496707584,496673644)

paulcam206
paulcam206 approved these changes May 28, 2019
View reviewed changes
Copy link
Member

@paulcam206 paulcam206 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@paulcam206 paulcam206 merged commit 11085ec into master May 28, 2019
@paulcam206 paulcam206 deleted the rebecch/sentimenttostyle branch May 28, 2019 22:08
andrewleader added a commit that referenced this pull request Jun 6, 2019
@andrewleader
Andrewleader/specing with types (#3033)
efb543c 
* TS bug fixes (#2966)

* [.NET][WPF][HTML] Fix Bleed behaviour for columns (#2879)

* Fix visibility issue for columns

* Fix separator issue in WPF

* Almost fix HTML renderer

* Fix toggle visibility select actions

* Add test for checking initial state of separators

* Fix html for hiding separators in initial state

* Fix logic in column separators

* Fix sample app to render tall cards

* Fix PR Comments

* Fix test files

* Fix test results

* Fix comments

* Add test app results

* Fix more comments

* Add results for new card

* Fix behaviour for bleed in WPF

* Fix HTML behavior

* Fix HTML tes

* Fix some of the PR comments

* Fix PR comments

* Jwoo/uwp italic strike through (#2970)

* fixes issue #2963

* updated for ios

* android update

* Review Comment Fix

* project file update per CR comments

* removed json files from /Expected per CR comments

* TS: Rename action.sentiment into action.style (#2981)

* TS: Rename action.sentiment into action.style

* Update one style

* Started working on schema-with-types

* Testing infrastructure

* Add URI support

* Add required support

* Refactor to class

* Add type references

* Add extending classes

* Add inehritance with referencing base class

* Rename sentiment to style (#2979)

* Update samples

* Update shared model

* Update UWP

* Udpate UWP tests

* Update .NET

* Udpate Android

* ios coresponding changes

* update project file

* Support multiple types for single property

* Add arrays

* Add tests for arrays of base types

* Add dictionary support

* Generate typed schema schema from typed schema itself

* Add typed schema schema

* Add booleans

* Disallow additional properties

* Add extends and schema to json schema

* updated sample host config file (#2989)

* Started updating some of the schema

* Reactnative/develop (#2990)

* Reactnative/experimental (#2918)

* Support for HeroCard and ThumbnailCard as an experiment

* Added react-native navigation support for Visualizer

* Updated visualizer with experimental items

* Revert "Added react-native navigation support for Visualizer"

This reverts commit 80688e5.

* Updated Visualiser with  tab to show the experimental items

* windows more option icon

* Show payloads tab by default

* Reactnative/fallback - Model layer and fallback feature (#2988)

* Support for HeroCard and ThumbnailCard as an experiment

* Added react-native navigation support for Visualizer

* Updated visualizer with experimental items

* Revert "Added react-native navigation support for Visualizer"

This reverts commit 80688e5.

* Updated Visualiser with  tab to show the experimental items

* windows more option icon

* Show payloads tab by default

* Model layer added and changes for fallback feature

* Media element updated in model

* Review comment fixes

* Fixed column visible issue and number input issue

* Added isNumber check for w2hRatio for Image

* Add ARM64 Support for UWP (#2931)

* Add ARM64 Support

* Update TargetPlatformMinVersion to 10.0.16299.0

* Add reference to sample host configs (#2967)

* Add reference to sample host configs

* fix typo

* [Android] Update readme.md (#2994)

Removes extra lines from end of file that made no sense

* Update README.md (#2993)

* Update README.md

* Update README.md

* Support multiple top-level types and other fixes

* updated iOS and Android project id for badges. (#2997)

* Fix not being able to add properties to extended classes

* Add ability to change property name of type property

* Support having a default type that doesn't need type specified

* New classType schema

* Add ContainerStyle enum

* Add VerticalContentAlignment

* Support default and required in schema

* Support any object type

* Update schemas

* Add nullable

* Add any arrays

* Update schemas

* Add shorthands

* Start writing more schema

* Allow type to not be specified at top level

* Infer type names from file name

* Add more schema

* Add marker interfaces

* Use compact transport controls (#2987)

* More elements

* Support recursive directories

* Rename to typed-schema

* Report more useful errors

* Start generating Adaptive Card schema

* Support enums

* Schema starting to work!

* Fix incorrect container property

* Fix extended classes not allowing extended properties

* Rename to src folder

* Adding columns

* Publish

 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]

* Closer to multiple tiers of extending

* Support multiple inheritance

* Throw errors on unknown types

* Rename to BlockElement

* Add FactSet

* Add ImageSet

* Add Input.Text

* Added all inputs

* Add typed classes for the parser

* Create overall Schema type object

* Support loading schema from folder

* Almost got spec generation working with new format!

* Update README.md (#3015)

* [UWP] Build perf improvements (#3004)

* Add ActionSet

* Cumulative ColumnSet fixes from Bug bash (#3008)

* Fix selectAction exception on empty ColumnSet

* Hide ColumnSet horizontal overflow

* Markdown generation is getting there!

* Markdown generation almost done

* Generate enum specs

* Add enum value description support

* [Security] Bump tar from 2.2.1 to 2.2.2 in /source/nodejs (#2980)

Bumps [tar](https://github.com/npm/node-tar) from 2.2.1 to 2.2.2. **This update includes security fixes.**
- [Release notes](https://github.com/npm/node-tar/releases)
- [Commits](isaacs/node-tar@v2.2.1...v2.2.2)

* Add shorthand property to classes

* [UWP][TestApp] Update host configs used by the UWP test app (#3018)

* [UWP] Test app code updates for host config changes

* [Samples] Update sample test host configs

* [UWP] Update test files

* CR feedback

* Update schema to support shorthand

* Update schema file

* Include lib

* Updated schema

* Add RichTextBlock

* Re-organize

* Change image uris to strings for relative urls

* Add Style property to Card

* Add Action.ToggleVisibility

* Add style to actions

* Remove duplicative BlockElement properties

* Add fallback

* Update wrap property on inputs

* Generated

* Update Input.Text selectAction

* Generate

* Add some versions

* Fix blank allOf

* Added a test that tests our samples

* Add horizontalAlignment to richtextblock

* Add minHeight

* Add minHeight to AdaptiveCard

* Add isVisible

* Update package-lock.json

* Add verticalContentAlignment to Adaptive Card

* Add height to container and columnset

* Add height to Column

* Add height to all elements

* Support overriding properties

* Fix image height property

* Fix overriding of inherited properties

* Update adaptive-card-new.json

* Make Column.items not required

* All samples valid

* Use uri-reference

* Support allowAdditionalProperties

* Allow custom enums

* card.style version = 1.2

* Include build-model

* Correctly display version number in markdown

* Support shorthands in markdown and fix background image version

* Remove generate-specs from website

* Generating site from new schema partially working

* Site generating properties

* Fix schema literals in website properties

* Make inherited detailed properties appear, and fix examples for properties

* Make type appear correctly on markdown tables

* Update toc

* Add new elements

* Re-order version property

* Show type type in type

* Support displaying enum value versions

* Style the default value correctly

* Indicate that type on inlines is required

* Support inline shorthand

* Improve image size documentation

* Fix inlineAction description

* Surface required properties at top of table

* Remove local marked-schema

* Rename BlockElement to Element

* Dispaly uri-reference as uri

* Rename fonttype sample

* Add expense report example

* Update schema file in sample

* Update ExpenseReport to use Submit

* Support case insensitive enums
rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request May 8, 2024
@paulcam206
Rename sentiment to style (microsoft#2979)
44f0990 
* Update samples

* Update shared model

* Update UWP

* Udpate UWP tests

* Update .NET

* Udpate Android

* ios coresponding changes

* update project file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almedina-ms almedina-ms almedina-ms approved these changes

@shalinijoshi19 shalinijoshi19 shalinijoshi19 approved these changes

@paulcam206 paulcam206 paulcam206 approved these changes

Assignees
No one assigned
Labels
Needs: Author Feedback Platform-.NET Platform-Android Platform-iOS Platform-Shared Model Platform-XAML Bugs or features related to Xaml Renderer
Projects
None yet
Milestone
No milestone
5 participants
@RebeccaAnne @jwoo-msft @paulcam206 @almedina-ms @shalinijoshi19