[UWP] Fix build break problems for some VS users #2965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you could update the description to explain the change a bit more, that would be great. |
done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2922
Still not entirely sure why this is only broken for some folks. Possibly because we shouldn't have been using the UnionMetadata in the first place, but this seems to work properly.
Specifically, rather than relying on the UnionMetadata winmd, which (I guess?) might vary based on machine state, we explicitly rely on the winmds we require -- the Foundation (for WinRT) and UniversalContract (for XAML) winmds.
Verified by building/running the visualizer
Microsoft Reviewers: Open in CodeFlow