[Android] Add data URI support #2133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcam206
reviewed
Oct 29, 2018
| "version": "1.0", | ||
| "body": [ | ||
| { | ||
| "type": "Image", |
There was a problem hiding this comment.
[](start = 0, length = 12)
We're supposed to be using tabs here. You should probably take a moment to enable EditorConfig support for Android Studio. :)
…dd support for resource resolver
…dd support for resource resolver
…dd support for resource resolver
…dd support for resource resolver
…dd support for resource resolver
…dd support for resource resolver
…dd support for resource resolver
…dd support for resource resolver
…dd support for resource resolver
…Microsoft/AdaptiveCards into user/almedina-ms/AndroidDataUri
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves this issue: #2129
I also took the liberty to fix a couple issues that I hadnt seen/thought about before, mainly about moving the default online loader method back to the GenericImageLoader and small extra stuff
This is now based on the UWP pull request, so that one must be merged first