-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[.NET] FontStyle Implementation #1988
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlos-zamora
added
Platform-.NET
Platform-JavaScript
Bugs or features related to the JavaScript renderer
labels
Oct 3, 2018
khouzam
reviewed
Oct 4, 2018
khouzam
reviewed
Oct 4, 2018
source/dotnet/Library/AdaptiveCards.Rendering.Wpf/AdaptiveActionRenderer.cs
Outdated
Show resolved
Hide resolved
khouzam
reviewed
Oct 4, 2018
source/dotnet/Library/AdaptiveCards.Rendering.Html/AdaptiveCardRenderer.cs
Outdated
Show resolved
Hide resolved
RebeccaAnne
reviewed
Oct 5, 2018
RebeccaAnne
reviewed
Oct 10, 2018
RebeccaAnne
reviewed
Oct 10, 2018
…nt-family tag won't appear if not set\r* default font family is now up to platform
Merged
paulcam206
reviewed
Oct 22, 2018
paulcam206
reviewed
Oct 22, 2018
source/dotnet/Library/AdaptiveCards/Rendering/FontStylesConfig.cs
Outdated
Show resolved
Hide resolved
paulcam206
reviewed
Oct 22, 2018
paulcam206
requested changes
Oct 22, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕐
…font family from Default style and deprecated value. Goes directly to special constant.
khouzam
reviewed
Oct 25, 2018
paulcam206
approved these changes
Oct 26, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for #1078 on .NET platform (#1967)
HostConfig
now has the followingFontStylesConfig
:Default
,Display
,Monospace
.Each
FontStyleConfig
has aFontFamilyConfig
, aFontWeightConfig
, and aFontSizeConfig
.The top-level
FontFamily
,FontSizes
andFontWeights
is now deprecated.Testing
Created
TextBlock.FontStyles.json
to test different text blocks using different styles. On my own tested weight and sizes and they work too (can't tell the difference between weight of 200 and 400 but dev mode on Edge says they are set differently).Also created 2 new host configs:
sampleFontStyles.json
: all font styles definedsampleMissingFontStyles.json
: onlyDefault
is definedI used
sample.json
andsampleDifferentText.json
to test inheritance from deprecated properties.Notes
GetFontWeight()
andGetFontSize()
are fast ways of returning the desired property.GetDefaultFontWeight()
andGetDefaultFontSize()
return the constant default (not fontStyleDefault
).GetFontWeight()
,GetFontSize()
, andGetFontFamily()
look a little weird but way cleaner than expanding it out. Let me know your thoughts on how to make it more legible though.