Skip to content

Commit

Permalink
Fix container styles not being properly applied in deep element hiera…
Browse files Browse the repository at this point in the history
…rchies (#1783)

* Plain Concepts’ PR with the Adaptive Cards designer. (#1722)

* fixed bug

* Updated package.json

* basic tree view

* update package.json

* Updated types

* Set selected item color

* Added actions to treeview

* Select peer in treeview

* Changed hardcoded comparations

* Fixed function definition

* fixed selecter peer on drag element

* Basic list style (#4)

* Feature/treeview folding (#5)

* Basic list style

* treeview folding

* Added rotated arrow (#6)

* Added rotated arrow

* Fixed quotation marks and removed console.log

* Feature/elements add icons (#7)

* Element icons class

* Added icons and section-header component

* Finished 51472: [UI] + [Functionality] View tree view

* Moved treeview to a new class

* Fixed build crash (#8)

* Added copy to clipboard functionality (#9)

* Added copy to clipboard functionality

* Removed Add New Card button from HTML

* Update tree view from json (#10)

* Refactored fullscreen functionality and added CopyJSON (#11)

* Refactored fullscreen functionality and added CopyJSON

* Removed unnecesary console.logs

* Finished navbar (#12)

* Added aside-items styles (#13)

* Added aside-items styles

* Added icon date

* Moved functions to utils

* Finished aside (#14)

* Finished aside

* Fixed toolbox title

* Feature/aside titles (#15)

* Finished aside

* Fixed toolbox title

* Maded aside toggleable

* Fixed toolbox when toggled

* Small class refactor

* Finished treeview togglable

* Maded properties panel togglable

* Added missing icons, optimized old icons and added needed CSS to view new icons

* Moved toggle toolbox, treeview and properties funcionality to app.ts and refactored element properties cleaning

* Removed .png icons and added .svg icons (#16)

* Feature/element properties styles (#17)

* Changed some element property styles

* Finished properties panel

* Fix/missing icons (#18)

* Removed unnecesary png icons

* Added missing arrow SVG icons

* Feature/51478 add hosts (#19)

* Added bf-image container

* Added teams-container

* Feature/51478 add hosts (#20)

* Added bf-image container

* Added teams-container

* Added webchat-container

* Optimized images and added timeline container (#21)

* Added toast host (#22)

* Added toast host

* Fixed class name

* Fixed card width

* Fixed IE problem with includes method (#23)

* Added BF other channels host (#24)

* Feature/51481 card layout (#25)

* Maded treeview and properties panel fold into aside-panel

* Finished folding panels

* Fix/history review (#26)

* Changed navbar text

* Added JSON Title

* Added icon when fullscreen

* Removed unnecesary sanitizeName functionality

* Feature/card design layout (#27)

* Changd top properties panel background-color

* Removed word Show when panels are closed

* Comment timeline host

* Added new card icons

* Finished feature/51481-card-layout

* Fixed navbar height (#28)

* Fix/ms feedback (#29)

* Fixed 52675-review-hosts-background

* Fix 52679-visual-tree-view-panel-has-two-different-bgcolors-when-scroll

* Finished task: 52617-adaptivecard node should be displayed in tree view

* Fixes 52616

* Feature/prepare pr (#31)

* Add MSC directive to prevent cppcorecheck build failures on non-VS builds (#1552)

* cleaned up exception handling in loading image (#1526)

* Enable member init checks and fix errors (#1566)

* A class with only static methods and no state should just be a namespace. (#1567)

* Support OnParseAction Handler (#1570)

* Honour preexpandSingleShowCardAction and weight of fact title from HostConfig

* Addressed comments

* Support OnParseAction

* resolved minor comments

* Jwoo/ios render sync (#1547)

* make rendering to be syncronoush by default

* updated custom textblock renderer

* changes before CR

* CR update

* CR update

* [.NET] Prevent async exceptions from tearing down the process (#1561)

* Prevent unobserved exceptions from taking down the process.

If rendering fails, report the error but do not throw on a background thread.

* Add configuration to sign nuget packages

* fixed dll/project names in comments

* Fix actions parent not being set before actions are parsed (#1573)

* Replace ContainerStyle string enum with class + static fields

* Update default card

* Improve hover behavior for Image with selectAction

* Finalize support for width/height in Image and Column

* Add support for icons on action buttons

* Cleanup

* Fix handling of buttons without title

* Fix broken preExpandSingleShowCardAction handling

* Fix actions parent not being set before actions are parsed

* Enable const cppcore checks and fix fallout (#1575)

* Add Events for media play and end (#1546)

* [Android] Add vertical stretch property (#1525)

* Add vertical stretch to android

* Remove non related test file

* Fix comments in FactSetRendered

* Add tests as linked tests

* Update tests results from TestApp with new tests

* Jwoo/ios makrdown optimized (#1554)

* make rendering to be syncronoush by default

* updated custom textblock renderer

* optimized use of html rendering

* fixed factset issue

* fixed build compatability issues below iOS 11.3

* fixes before CR

* CR comments fix

* Added additional headers to public lis in framework. (#1562)

* make rendering to be syncronoush by default

* updated custom textblock renderer

* optimized use of html rendering

* fixed factset issue

* made headers public for customizing buttons

* added ACRUILable.h

* reverted wrong merge

* Enable CPPCORECHECK_DECLARATION_WARNINGS and fix errors (#1579)

* Enable Declaration warnings and first round of fixes

* Clean up remaining unnamed objects warnings and disable C26426 in enums.cpp

* added ability to scroll when there are more buttons than viewing area (#1581)

* make rendering to be syncronoush by default

* updated custom textblock renderer

* optimized use of html rendering

* fixed factset issue

* fixed build compatability issues below iOS 11.3

* fixes before CR

* added UIScrollView to ActionSet

* edits before CR

* Added sample json and updates b4 CR

* Enable "rule of five" checker, fix errors (#1585)

* Add Teams containers (#1469)

Add support for more properties in property sheet
Add initial support for snippets

* [iOS] Add vertical stretch support (#1584)

* Add vertical stretch to android

* make rendering to be syncronoush by default

* updated custom textblock renderer

* optimized use of html rendering

* fixed factset issue

* Remove non related test file

* Fix comments in FactSetRendered

* Add tests as linked tests

* Update tests results from TestApp with new tests

* Add vertical stretch for items

* Remove 'changes' from merge

* Add vertical stretch tests to solution

* Fix issue for image in columnsets rendering

* Fix issue for images being shorter than other columns in columnset

* Keep alignment leading for cards with no stretchable items

* Add new test for auto size image

* Enable all cppcorecheck class warnings and fix errors (#1601)

* Enable override checker and fix errors

* Enable function hiding warning and fix errors

* Enable all class warnings and fix errors

* [iOS] Add missing test for Vertical Stretch (#1603)

* Add missing test

* Fix spaces in json

* Update GetResource method to include type and to support media   (#1583)

* Update get resource method to include type and to support media

* Handle opening media via resource resolver when play is pressed (#1586)

Handle opening media via resource resolver when play is pressed

* Enable unit test code coverage in Debug Win32 builds (#1611)

* Test source file updates (#1551)

* Test file updates

* Jwoo/ios custom styling (#1474)

* XIB first commit

* fixes merge error

* updated InputView with XIB

updated the style of UIButtons

 added UITableViewCell xib for compact mode

removed comments

* code clean up

* added ACRbutton.xib

* Added Xib for CompactCell

* added ACRButton.xib

* allowed column with numeric width value to stretch (#1595)

* allowed column with numeric width value to stretch

* fix merge and remove spacing for the first item

* [UWP][Android][iOS] Add aesthetic fix Icons in Actions (#1612)

* Add aesthetic fix to UWP

* Aesthetic fix for android

* Aesthetic fix for iOS

* Add json test files to project

* Fix formatting

* updated showcard rendering position (#1600)

removed comments

* compact style choice set "make choice" row will reflect user choice (#1596)

* in progress

* when user chooses, user choice will be shown

* updated default message

* value is used instead of "Make Choice"

* handles cases where compact style lacking defaults (#1627)

* fixed separator issue (#1629)

* Remove Stretch from vertical content alignment (#1630)

* Jwoo/explicit image size ios (#1374)

* explicit image changes

* Added 'Explicit' enum value

* uwp changes

* uwp changes

* added explicit image sizing option for ios

* removed division

* fixes extra spacing issue in UICollectionView (#1628)

* fixes extra spacing issue in UICollectionView

* refined intrinsic content size for collection view

* fixed precision error

* fixes url loading sync issue for actions (#1641)

* fixes url loading sync issue for actions

removed hard coded image icon placement

* fixed indentation and changed variable name

* Fix media controls (#1614)

* [TS] Fixed Input.Text style and horizontalAlignment roundtrip; added test (#1636)

* Input.Text roundtrip, added test and fix

* feedback -vertical spaces

* Change private for protected in all Renderers constructors (#1649)

* Add vertical scroll support (#1650)

* Jwoo/ios custom background image loader (#1642)

* fixes url loading sync issue for actions

removed hard coded image icon placement

* allows custom BG IMG renderer

* Added CustomImageRenderer to sample

* removed CoreGraphics framework as it's not used

* added a test to ensure Unicode/Emoji support (#1647)

:shipit:

* multiline input and input limit for textview and textfield (#1643)

* initial commit for multiline input and input limit

implmt plc hld txt; rmved max len chg when not set

reverted json files

* Refactoring and code clean-up

* updated whitespaces

* Fixed newline char

* [Android] Refocus when a show card changes visibility (#1651)

* Refocus on show card

* Set focus for cards instead of input fields

* Revert "[Android] Refocus when a show card changes visibility (#1651)" (#1653)

This reverts commit f2a899a17eb686a42debb39dd1ac876ab8a3b629.

* Fix/ms feedback (#30)

* Add MSC directive to prevent cppcorecheck build failures on non-VS builds (#1552)

* cleaned up exception handling in loading image (#1526)

* Enable member init checks and fix errors (#1566)

* A class with only static methods and no state should just be a namespace. (#1567)

* Support OnParseAction Handler (#1570)

* Honour preexpandSingleShowCardAction and weight of fact title from HostConfig

* Addressed comments

* Support OnParseAction

* resolved minor comments

* Jwoo/ios render sync (#1547)

* make rendering to be syncronoush by default

* updated custom textblock renderer

* changes before CR

* CR update

* CR update

* [.NET] Prevent async exceptions from tearing down the process (#1561)

* Prevent unobserved exceptions from taking down the process.

If rendering fails, report the error but do not throw on a background thread.

* Add configuration to sign nuget packages

* fixed dll/project names in comments

* Fix actions parent not being set before actions are parsed (#1573)

* Replace ContainerStyle string enum with class + static fields

* Update default card

* Improve hover behavior for Image with selectAction

* Finalize support for width/height in Image and Column

* Add support for icons on action buttons

* Cleanup

* Fix handling of buttons without title

* Fix broken preExpandSingleShowCardAction handling

* Fix actions parent not being set before actions are parsed

* Enable const cppcore checks and fix fallout (#1575)

* Add Events for media play and end (#1546)

* [Android] Add vertical stretch property (#1525)

* Add vertical stretch to android

* Remove non related test file

* Fix comments in FactSetRendered

* Add tests as linked tests

* Update tests results from TestApp with new tests

* Jwoo/ios makrdown optimized (#1554)

* make rendering to be syncronoush by default

* updated custom textblock renderer

* optimized use of html rendering

* fixed factset issue

* fixed build compatability issues below iOS 11.3

* fixes before CR

* CR comments fix

* Added additional headers to public lis in framework. (#1562)

* make rendering to be syncronoush by default

* updated custom textblock renderer

* optimized use of html rendering

* fixed factset issue

* made headers public for customizing buttons

* added ACRUILable.h

* reverted wrong merge

* Enable CPPCORECHECK_DECLARATION_WARNINGS and fix errors (#1579)

* Enable Declaration warnings and first round of fixes

* Clean up remaining unnamed objects warnings and disable C26426 in enums.cpp

* added ability to scroll when there are more buttons than viewing area (#1581)

* make rendering to be syncronoush by default

* updated custom textblock renderer

* optimized use of html rendering

* fixed factset issue

* fixed build compatability issues below iOS 11.3

* fixes before CR

* added UIScrollView to ActionSet

* edits before CR

* Added sample json and updates b4 CR

* Enable "rule of five" checker, fix errors (#1585)

* Add Teams containers (#1469)

Add support for more properties in property sheet
Add initial support for snippets

* [iOS] Add vertical stretch support (#1584)

* Add vertical stretch to android

* make rendering to be syncronoush by default

* updated custom textblock renderer

* optimized use of html rendering

* fixed factset issue

* Remove non related test file

* Fix comments in FactSetRendered

* Add tests as linked tests

* Update tests results from TestApp with new tests

* Add vertical stretch for items

* Remove 'changes' from merge

* Add vertical stretch tests to solution

* Fix issue for image in columnsets rendering

* Fix issue for images being shorter than other columns in columnset

* Keep alignment leading for cards with no stretchable items

* Add new test for auto size image

* Enable all cppcorecheck class warnings and fix errors (#1601)

* Enable override checker and fix errors

* Enable function hiding warning and fix errors

* Enable all class warnings and fix errors

* [iOS] Add missing test for Vertical Stretch (#1603)

* Add missing test

* Fix spaces in json

* Update GetResource method to include type and to support media   (#1583)

* Update get resource method to include type and to support media

* Handle opening media via resource resolver when play is pressed (#1586)

Handle opening media via resource resolver when play is pressed

* Enable unit test code coverage in Debug Win32 builds (#1611)

* Test source file updates (#1551)

* Test file updates

* Jwoo/ios custom styling (#1474)

* XIB first commit

* fixes merge error

* updated InputView with XIB

updated the style of UIButtons

 added UITableViewCell xib for compact mode

removed comments

* code clean up

* added ACRbutton.xib

* Added Xib for CompactCell

* added ACRButton.xib

* allowed column with numeric width value to stretch (#1595)

* allowed column with numeric width value to stretch

* fix merge and remove spacing for the first item

* [UWP][Android][iOS] Add aesthetic fix Icons in Actions (#1612)

* Add aesthetic fix to UWP

* Aesthetic fix for android

* Aesthetic fix for iOS

* Add json test files to project

* Fix formatting

* updated showcard rendering position (#1600)

removed comments

* compact style choice set "make choice" row will reflect user choice (#1596)

* in progress

* when user chooses, user choice will be shown

* updated default message

* value is used instead of "Make Choice"

* handles cases where compact style lacking defaults (#1627)

* fixed separator issue (#1629)

* Remove Stretch from vertical content alignment (#1630)

* Jwoo/explicit image size ios (#1374)

* explicit image changes

* Added 'Explicit' enum value

* uwp changes

* uwp changes

* added explicit image sizing option for ios

* removed division

* fixes extra spacing issue in UICollectionView (#1628)

* fixes extra spacing issue in UICollectionView

* refined intrinsic content size for collection view

* fixed precision error

* fixes url loading sync issue for actions (#1641)

* fixes url loading sync issue for actions

removed hard coded image icon placement

* fixed indentation and changed variable name

* Fix media controls (#1614)

* [TS] Fixed Input.Text style and horizontalAlignment roundtrip; added test (#1636)

* Input.Text roundtrip, added test and fix

* feedback -vertical spaces

* Change private for protected in all Renderers constructors (#1649)

* Add vertical scroll support (#1650)

* Jwoo/ios custom background image loader (#1642)

* fixes url loading sync issue for actions

removed hard coded image icon placement

* allows custom BG IMG renderer

* Added CustomImageRenderer to sample

* removed CoreGraphics framework as it's not used

* added a test to ensure Unicode/Emoji support (#1647)

:shipit:

* multiline input and input limit for textview and textfield (#1643)

* initial commit for multiline input and input limit

implmt plc hld txt; rmved max len chg when not set

reverted json files

* Refactoring and code clean-up

* updated whitespaces

* Fixed newline char

* Fixed 52675-review-hosts-background

* Fix 52679-visual-tree-view-panel-has-two-different-bgcolors-when-scroll

* Finished task: 52617-adaptivecard node should be displayed in tree view

* Fixes 52616

* Fixed Properties panel separation

* Feature/prepare pull request (#32)

* Add MSC directive to prevent cppcorecheck build failures on non-VS builds (#1552)

* cleaned up exception handling in loading image (#1526)

* Enable member init checks and fix errors (#1566)

* A class with only static methods and no state should just be a namespace. (#1567)

* Support OnParseAction Handler (#1570)

* Honour preexpandSingleShowCardAction and weight of fact title from HostConfig

* Addressed comments

* Support OnParseAction

* resolved minor comments

* Jwoo/ios render sync (#1547)

* make rendering to be syncronoush by default

* updated custom textblock renderer

* changes before CR

* CR update

* CR update

* [.NET] Prevent async exceptions from tearing down the process (#1561)

* Prevent unobserved exceptions from taking down the process.

If rendering fails, report the error but do not throw on a background thread.

* Add configuration to sign nuget packages

* fixed dll/project names in comments

* Fix actions parent not being set before actions are parsed (#1573)

* Replace ContainerStyle string enum with class + static fields

* Update default card

* Improve hover behavior for Image with selectAction

* Finalize support for width/height in Image and Column

* Add support for icons on action buttons

* Cleanup

* Fix handling of buttons without title

* Fix broken preExpandSingleShowCardAction handling

* Fix actions parent not being set before actions are parsed

* Enable const cppcore checks and fix fallout (#1575)

* Add Events for media play and end (#1546)

* [Android] Add vertical stretch property (#1525)

* Add vertical stretch to android

* Remove non related test file

* Fix comments in FactSetRendered

* Add tests as linked tests

* Update tests results from TestApp with new tests

* Jwoo/ios makrdown optimized (#1554)

* make rendering to be syncronoush by default

* updated custom textblock renderer

* optimized use of html rendering

* fixed factset issue

* fixed build compatability issues below iOS 11.3

* fixes before CR

* CR comments fix

* Added additional headers to public lis in framework. (#1562)

* make rendering to be syncronoush by default

* updated custom textblock renderer

* optimized use of html rendering

* fixed factset issue

* made headers public for customizing buttons

* added ACRUILable.h

* reverted wrong merge

* Enable CPPCORECHECK_DECLARATION_WARNINGS and fix errors (#1579)

* Enable Declaration warnings and first round of fixes

* Clean up remaining unnamed objects warnings and disable C26426 in enums.cpp

* added ability to scroll when there are more buttons than viewing area (#1581)

* make rendering to be syncronoush by default

* updated custom textblock renderer

* optimized use of html rendering

* fixed factset issue

* fixed build compatability issues below iOS 11.3

* fixes before CR

* added UIScrollView to ActionSet

* edits before CR

* Added sample json and updates b4 CR

* Enable "rule of five" checker, fix errors (#1585)

* Add Teams containers (#1469)

Add support for more properties in property sheet
Add initial support for snippets

* [iOS] Add vertical stretch support (#1584)

* Add vertical stretch to android

* make rendering to be syncronoush by default

* updated custom textblock renderer

* optimized use of html rendering

* fixed factset issue

* Remove non related test file

* Fix comments in FactSetRendered

* Add tests as linked tests

* Update tests results from TestApp with new tests

* Add vertical stretch for items

* Remove 'changes' from merge

* Add vertical stretch tests to solution

* Fix issue for image in columnsets rendering

* Fix issue for images being shorter than other columns in columnset

* Keep alignment leading for cards with no stretchable items

* Add new test for auto size image

* Enable all cppcorecheck class warnings and fix errors (#1601)

* Enable override checker and fix errors

* Enable function hiding warning and fix errors

* Enable all class warnings and fix errors

* [iOS] Add missing test for Vertical Stretch (#1603)

* Add missing test

* Fix spaces in json

* Update GetResource method to include type and to support media   (#1583)

* Update get resource method to include type and to support media

* Handle opening media via resource resolver when play is pressed (#1586)

Handle opening media via resource resolver when play is pressed

* Enable unit test code coverage in Debug Win32 builds (#1611)

* Test source file updates (#1551)

* Test file updates

* Jwoo/ios custom styling (#1474)

* XIB first commit

* fixes merge error

* updated InputView with XIB

updated the style of UIButtons

 added UITableViewCell xib for compact mode

removed comments

* code clean up

* added ACRbutton.xib

* Added Xib for CompactCell

* added ACRButton.xib

* allowed column with numeric width value to stretch (#1595)

* allowed column with numeric width value to stretch

* fix merge and remove spacing for the first item

* [UWP][Android][iOS] Add aesthetic fix Icons in Actions (#1612)

* Add aesthetic fix to UWP

* Aesthetic fix for android

* Aesthetic fix for iOS

* Add json test files to project

* Fix formatting

* updated showcard rendering position (#1600)

removed comments

* compact style choice set "make choice" row will reflect user choice (#1596)

* in progress

* when user chooses, user choice will be shown

* updated default message

* value is used instead of "Make Choice"

* handles cases where compact style lacking defaults (#1627)

* fixed separator issue (#1629)

* Remove Stretch from vertical content alignment (#1630)

* Jwoo/explicit image size ios (#1374)

* explicit image changes

* Added 'Explicit' enum value

* uwp changes

* uwp changes

* added explicit image sizing option for ios

* removed division

* fixes extra spacing issue in UICollectionView (#1628)

* fixes extra spacing issue in UICollectionView

* refined intrinsic content size for collection view

* fixed precision error

* fixes url loading sync issue for actions (#1641)

* fixes url loading sync issue for actions

removed hard coded image icon placement

* fixed indentation and changed variable name

* Fix media controls (#1614)

* [TS] Fixed Input.Text style and horizontalAlignment roundtrip; added test (#1636)

* Input.Text roundtrip, added test and fix

* feedback -vertical spaces

* Change private for protected in all Renderers constructors (#1649)

* Add vertical scroll support (#1650)

* Jwoo/ios custom background image loader (#1642)

* fixes url loading sync issue for actions

removed hard coded image icon placement

* allows custom BG IMG renderer

* Added CustomImageRenderer to sample

* removed CoreGraphics framework as it's not used

* added a test to ensure Unicode/Emoji support (#1647)

:shipit:

* multiline input and input limit for textview and textfield (#1643)

* initial commit for multiline input and input limit

implmt plc hld txt; rmved max len chg when not set

reverted json files

* Refactoring and code clean-up

* updated whitespaces

* Fixed newline char

* [Android] Refocus when a show card changes visibility (#1651)

* Refocus on show card

* Set focus for cards instead of input fields

* Revert "[Android] Refocus when a show card changes visibility (#1651)" (#1653)

This reverts commit f2a899a17eb686a42debb39dd1ac876ab8a3b629.

* Fixed conflict

* 52619-to-much-padding-in-tree-view

* 52614-tree-view-is-very-messy-as-it-is-resized-to-limited-width

* Reverted to Fabric UI instead of SVGs (#33)

* Reverted to Fabric UI instead of SVGs

* Removed unnecesary comments

* Removed unnecesary CSS and duplicated one (#35)

* Fix/use hostconfig to add container styles (#36)

* background fix

* Added background color via CSS again

* Fixed some colours

* Fixed class names in CSS and HTML

* Moved interfaz to separate component

* Fixed action and add column styles

* Reverted removed commented code

* Removed CSS properties panel color modification

* Changed querySelector by getElementById

* Removed commented code

* Fix/hostconfig styles (#37)

* Changed SVGs to FabriUI Font

* Changed SVGs to FabriUI Font

* Changed aside-panel icons when folded

* Added cursor pointer to panel headers and avoided user-select it's text

* Added cursor pointer to properties/treewview panels when folded

* Added treeview icon fonts from FabricUI instead of SVGs

* Fixed treeview icons positon

* Fix/treeview implementation (#38)

* Half of treeview refactor

* Finished treeview

* Removed unnecesary btn class and fixed treeview icons position

* Removed unnecesary treeview component

* Removed outline as David Claux did to match he's style

* Mantained folded state when needed

* Removed unnecesary console.log

* Removed unnecesary icons (#39)

* Fix/minor microsoft pr changes (#40)

* Removed unnecesary icons

* Removed blank line

* Fix/phase 0 (#41)

* Changed aside panel background's color

* Maded JSON togglable

* Refactored CSS

* Fixed PR comments

* Fix/phase 0 (#43)

* Changed aside panel background's color

* Maded JSON togglable

* Refactored CSS

* Fixed PR comments

* Removed unnecesary code

* Fix/develop (#44)

* Add MSC directive to prevent cppcorecheck build failures on non-VS builds (#1552)

* cleaned up exception handling in loading image (#1526)

* Enable member init checks and fix errors (#1566)

* A class with only static methods and no state should just be a namespace. (#1567)

* Support OnParseAction Handler (#1570)

* Honour preexpandSingleShowCardAction and weight of fact title from HostConfig

* Addressed comments

* Support OnParseAction

* resolved minor comments

* Jwoo/ios render sync (#1547)

* make rendering to be syncronoush by default

* updated custom textblock renderer

* changes before CR

* CR update

* CR update

* [.NET] Prevent async exceptions from tearing down the process (#1561)

* Prevent unobserved exceptions from taking down the process.

If rendering fails, report the error but do not throw on a background thread.

* Add configuration to sign nuget packages

* fixed dll/project names in comments

* Fix actions parent not being set before actions are parsed (#1573)

* Replace ContainerStyle string enum with class + static fields

* Update default card

* Improve hover behavior for Image with selectAction

* Finalize support for width/height in Image and Column

* Add support for icons on action buttons

* Cleanup

* Fix handling of buttons without title

* Fix broken preExpandSingleShowCardAction handling

* Fix actions parent not being set before actions are parsed

* Enable const cppcore checks and fix fallout (#1575)

* Add Events for media play and end (#1546)

* [Android] Add vertical stretch property (#1525)

* Add vertical stretch to android

* Remove non related test file

* Fix comments in FactSetRendered

* Add tests as linked tests

* Update tests results from TestApp with new tests

* Jwoo/ios makrdown optimized (#1554)

* make rendering to be syncronoush by default

* updated custom textblock renderer

* optimized use of html rendering

* fixed factset issue

* fixed build compatability issues below iOS 11.3

* fixes before CR

* CR comments fix

* Added additional headers to public lis in framework. (#1562)

* make rendering to be syncronoush by default

* updated custom textblock renderer

* optimized use of html rendering

* fixed factset issue

* made headers public for customizing buttons

* added ACRUILable.h

* reverted wrong merge

* Enable CPPCORECHECK_DECLARATION_WARNINGS and fix errors (#1579)

* Enable Declaration warnings and first round of fixes

* Clean up remaining unnamed objects warnings and disable C26426 in enums.cpp

* added ability to scroll when there are more buttons than viewing area (#1581)

* make rendering to be syncronoush by default

* updated custom textblock renderer

* optimized use of html rendering

* fixed factset issue

* fixed build compatability issues below iOS 11.3

* fixes before CR

* added UIScrollView to ActionSet

* edits before CR

* Added sample json and updates b4 CR

* Enable "rule of five" checker, fix errors (#1585)

* Add Teams containers (#1469)

Add support for more properties in property sheet
Add initial support for snippets

* [iOS] Add vertical stretch support (#1584)

* Add vertical stretch to android

* make rendering to be syncronoush by default

* updated custom textblock renderer

* optimized use of html rendering

* fixed factset issue

* Remove non related test file

* Fix comments in FactSetRendered

* Add tests as linked tests

* Update tests results from TestApp with new tests

* Add vertical stretch for items

* Remove 'changes' from merge

* Add vertical stretch tests to solution

* Fix issue for image in columnsets rendering

* Fix issue for images being shorter than other columns in columnset

* Keep alignment leading for cards with no stretchable items

* Add new test for auto size image

* Enable all cppcorecheck class warnings and fix errors (#1601)

* Enable override checker and fix errors

* Enable function hiding warning and fix errors

* Enable all class warnings and fix errors

* [iOS] Add missing test for Vertical Stretch (#1603)

* Add missing test

* Fix spaces in json

* Update GetResource method to include type and to support media   (#1583)

* Update get resource method to include type and to support media

* Handle opening media via resource resolver when play is pressed (#1586)

Handle opening media via resource resolver when play is pressed

* Enable unit test code coverage in Debug Win32 builds (#1611)

* Test source file updates (#1551)

* Test file updates

* Jwoo/ios custom styling (#1474)

* XIB first commit

* fixes merge error

* updated InputView with XIB

updated the style of UIButtons

 added UITableViewCell xib for compact mode

removed comments

* code clean up

* added ACRbutton.xib

* Added Xib for CompactCell

* added ACRButton.xib

* allowed column with numeric width value to stretch (#1595)

* allowed column with numeric width value to stretch

* fix merge and remove spacing for the first item

* [UWP][Android][iOS] Add aesthetic fix Icons in Actions (#1612)

* Add aesthetic fix to UWP

* Aesthetic fix for android

* Aesthetic fix for iOS

* Add json test files to project

* Fix formatting

* updated showcard rendering position (#1600)

removed comments

* compact style choice set "make choice" row will reflect user choice (#1596)

* in progress

* when user chooses, user choice will be shown

* updated default message

* value is used instead of "Make Choice"

* handles cases where compact style lacking defaults (#1627)

* fixed separator issue (#1629)

* Remove Stretch from vertical content alignment (#1630)

* Jwoo/explicit image size ios (#1374)

* explicit image changes

* Added 'Explicit' enum value

* uwp changes

* uwp changes

* added explicit image sizing option for ios

* removed division

* fixes extra spacing issue in UICollectionView (#1628)

* fixes extra spacing issue in UICollectionView

* refined intrinsic content size for collection view

* fixed precision error

* fixes url loading sync issue for actions (#1641)

* fixes url loading sync issue for actions

removed hard coded image icon placement

* fixed indentation and changed variable name

* Fix media controls (#1614)

* [TS] Fixed Input.Text style and horizontalAlignment roundtrip; added test (#1636)

* Input.Text roundtrip, added test and fix

* feedback -vertical spaces

* Change private for protected in all Renderers constructors (#1649)

* Add vertical scroll support (#1650)

* Jwoo/ios custom background image loader (#1642)

* fixes url loading sync issue for actions

removed hard coded image icon placement

* allows custom BG IMG renderer

* Added CustomImageRenderer to sample

* removed CoreGraphics framework as it's not used

* added a test to ensure Unicode/Emoji support (#1647)

:shipit:

* multiline input and input limit for textview and textfield (#1643)

* initial commit for multiline input and input limit

implmt plc hld txt; rmved max len chg when not set

reverted json files

* Refactoring and code clean-up

* updated whitespaces

* Fixed newline char

* [Android] Refocus when a show card changes visibility (#1651)

* Refocus on show card

* Set focus for cards instead of input fields

* Revert "[Android] Refocus when a show card changes visibility (#1651)" (#1653)

This reverts commit f2a899a17eb686a42debb39dd1ac876ab8a3b629.

* 52619-to-much-padding-in-tree-view

* 52614-tree-view-is-very-messy-as-it-is-resized-to-limited-width

* Reverted to Fabric UI instead of SVGs (#33)

* Reverted to Fabric UI instead of SVGs

* Removed unnecesary comments

* Removed unnecesary CSS and duplicated one (#35)

* Fix/use hostconfig to add container styles (#36)

* background fix

* Added background color via CSS again

* Fixed some colours

* Fixed class names in CSS and HTML

* Moved interfaz to separate component

* Fixed action and add column styles

* Reverted removed commented code

* Removed CSS properties panel color modification

* Changed querySelector by getElementById

* Removed commented code

* Fix/hostconfig styles (#37)

* Changed SVGs to FabriUI Font

* Changed SVGs to FabriUI Font

* Changed aside-panel icons when folded

* Added cursor pointer to panel headers and avoided user-select it's text

* Added cursor pointer to properties/treewview panels when folded

* Added treeview icon fonts from FabricUI instead of SVGs

* Fixed treeview icons positon

* Fix/treeview implementation (#38)

* Half of treeview refactor

* Finished treeview

* Removed unnecesary btn class and fixed treeview icons position

* Removed unnecesary treeview component

* Removed outline as David Claux did to match he's style

* Mantained folded state when needed

* Removed unnecesary console.log

* Removed unnecesary icons (#39)

* Fix/minor microsoft pr changes (#40)

* Removed unnecesary icons

* Removed blank line

* Fix/phase 0 (#41)

* Changed aside panel background's color

* Maded JSON togglable

* Refactored CSS

* Fixed PR comments

* Fix/phase 0 (#43)

* Changed aside panel background's color

* Maded JSON togglable

* Refactored CSS

* Fixed PR comments

* Removed unnecesary code

* Fix/json overflow (#46)

* Fixed JSON title width

* Moved to HTML monaco-editor's nav-title

* Fixed toggle class implementation when updatingLayout in the treeview

* Fixed aside scrollbar

* Fixed properties panel label's width

* Fixed JSON panel height when toggled

* Fixed properties panel paddings and FactSet padding-right and padding-left

* Fixed treeview background-color

* Fix/develop (#48)

* Add MSC directive to prevent cppcorecheck build failures on non-VS builds (#1552)

* cleaned up exception handling in loading image (#1526)

* Enable member init checks and fix errors (#1566)

* A class with only static methods and no state should just be a namespace. (#1567)

* Support OnParseAction Handler (#1570)

* Honour preexpandSingleShowCardAction and weight of fact title from HostConfig

* Addressed comments

* Support OnParseAction

* resolved minor comments

* Jwoo/ios render sync (#1547)

* make rendering to be syncronoush by default

* updated custom textblock renderer

* changes before CR

* CR update

* CR update

* [.NET] Prevent async exceptions from tearing down the process (#1561)

* Prevent unobserved exceptions from taking down the process.

If rendering fails, report the error but do not throw on a background thread.

* Add configuration to sign nuget packages

* fixed dll/project names in comments

* Fix actions parent not being set before actions are parsed (#1573)

* Replace ContainerStyle string enum with class + static fields

* Update default card

* Improve hover behavior for Image with selectAction

* Finalize support for width/height in Image and Column

* Add support for icons on action buttons

* Cleanup

* Fix handling of buttons without title

* Fix broken preExpandSingleShowCardAction handling

* Fix actions parent not being set before actions are parsed

* Enable const cppcore checks and fix fallout (#1575)

* Add Events for media play and end (#1546)

* [Android] Add vertical stretch property (#1525)

* Add vertical stretch to android

* Remove non related test file

* Fix comments in FactSetRendered

* Add tests as linked tests

* Update tests results from TestApp with new tests

* Jwoo/ios makrdown optimized (#1554)

* make rendering to be syncronoush by default

* updated custom textblock renderer

* optimized use of html rendering

* fixed factset issue

* fixed build compatability issues below iOS 11.3

* fixes before CR

* CR comments fix

* Added additional headers to public lis in framework. (#1562)

* make rendering to be syncronoush by default

* updated custom textblock renderer

* optimized use of html rendering

* fixed factset issue

* made headers public for customizing buttons

* added ACRUILable.h

* reverted wrong merge

* Enable CPPCORECHECK_DECLARATION_WARNINGS and fix errors (#1579)

* Enable Declaration warnings and first round of fixes

* Clean up remaining unnamed objects warnings and disable C26426 in enums.cpp

* added ability to scroll when there are more buttons than viewing area (#1581)

* make rendering to be syncronoush by default

* updated custom textblock renderer

* optimized use of html rendering

* fixed factset issue

* fixed build compatability issues below iOS 11.3

* fixes before CR

* added UIScrollView to ActionSet

* edits before CR

* Added sample json and updates b4 CR

* Enable "rule of five" checker, fix errors (#1585)

* Add Teams containers (#1469)

Add support for more properties in property sheet
Add initial support for snippets

* [iOS] Add vertical stretch support (#1584)

* Add vertical stretch to android

* make rendering to be syncronoush by default

* updated custom textblock renderer

* optimized use of html rendering

* fixed factset issue

* Remove non related test file

* Fix comments in FactSetRendered

* Add tests as linked tests

* Update tests results from TestApp with new tests

* Add vertical stretch for items

* Remove 'changes' from merge

* Add vertical stretch tests to solution

* Fix issue for image in columnsets rendering

* Fix issue for images being shorter than other columns in columnset

* Keep alignment leading for cards with no stretchable items

* Add new test for auto size image

* Enable all cppcorecheck class warnings and fix errors (#1601)

* Enable override checker and fix errors

* Enable function hiding warning and fix errors

* Enable all class warnings and fix errors

* [iOS] Add missing test for Vertical Stretch (#1603)

* Add missing test

* Fix spaces in json

* Update GetResource method to include type and to support media   (#1583)

* Update get resource method to include type and to support media

* Handle opening media via resource resolver when play is pressed (#1586)

Handle opening media via resource resolver when play is pressed

* Enable unit test code coverage in Debug Win32 builds (#1611)

* Test source file updates (#1551)

* Test file updates

* Jwoo/ios custom styling (#1474)

* XIB first commit

* fixes merge error

* updated InputView with XIB

updated the style of UIButtons

 added UITableViewCell xib for compact mode

removed comments

* code clean up

* added ACRbutton.xib

* Added Xib for CompactCell

* added ACRButton.xib

* allowed column with numeric width value to stretch (#1595)

* allowed column with numeric width value to stretch

* fix merge and remove spacing for the first item

* [UWP][Android][iOS] Add aesthetic fix Icons in Actions (#1612)

* Add aesthetic fix to UWP

* Aesthetic fix for android

* Aesthetic fix for iOS

* Add json test files to project

* Fix formatting

* updated showcard rendering position (#1600)

removed comments

* compact style choice set "make choice" row will reflect user choice (#1596)

* in progress

* when user chooses, user choice will be shown

* updated default message

* value is used instead of "Make Choice"

* handles cases where compact style lacking defaults (#1627)

* fixed separator issue (#1629)

* Remove Stretch from vertical content alignment (#1630)

* Jwoo/explicit image size ios (#1374)

* explicit image changes

* Added 'Explicit' enum value

* uwp changes

* uwp changes

* added explicit image sizing option for ios

* removed division

* fixes extra spacing issue in UICollectionView (#1628)

* fixes extra spacing issue in UICollectionView

* refined intrinsic content size for collection view

* fixed precision error

* fixes url loading sync issue for actions (#1641)

* fixes url loading sync issue for actions

removed hard coded image icon placement

* fixed indentation and changed variable name

* Fix media controls (#1614)

* [TS] Fixed Input.Text style and horizontalAlignment roundtrip; added test (#1636)

* Input.Text roundtrip, added test and fix

* feedback -vertical spaces

* Change private for protected in all Renderers constructors (#1649)

* Add vertical scroll support (#1650)

* Jwoo/ios custom background image loader (#1642)

* fixes url loading sync issue for actions

removed hard coded image icon placement

* allows custom BG IMG renderer

* Added CustomImageRenderer to sample

* removed CoreGraphics framework as it's not used

* added a test to ensure Unicode/Emoji support (#1647)

:shipit:

* multiline input and input limit for textview and textfield (#1643)

* initial commit for multiline input and input limit

implmt plc hld txt; rmved max len chg when not set

reverted json files

* Refactoring and code clean-up

* updated whitespaces

* Fixed newline char

* [Android] Refocus when a show card changes visibility (#1651)

* Refocus on show card

* Set focus for cards instead of input fields

* Revert "[Android] Refocus when a show card changes visibility (#1651)" (#1653)

This reverts commit f2a899a17eb686a42debb39dd1ac876ab8a3b629.

* 52619-to-much-padding-in-tree-view

* 52614-tree-view-is-very-messy-as-it-is-resized-to-limited-width

* Reverted to Fabric UI instead of SVGs (#33)

* Reverted to Fabric UI instead of SVGs

* Removed unnecesary comments

* Removed unnecesary CSS and duplicated one (#35)

* Fix/use hostconfig to add container styles (#36)

* background fix

* Added background color via CSS again

* Fixed some colours

* Fixed class names in CSS and HTML

* Moved interfaz to separate component

* Fixed action and add column styles

* Reverted removed commented code

* Removed CSS properties panel color modification

* Changed querySelector by getElementById

* Removed commented code

* Fix/hostconfig styles (#37)

* Changed SVGs to FabriUI Font

* Changed SVGs to FabriUI Font

* Changed aside-panel icons when folded

* Added cursor pointer to panel headers and avoided user-select it's text

* Added cursor pointer to properties/treewview panels when folded

* Added treeview icon fonts from FabricUI instead of SVGs

* Fixed treeview icons positon

* Fix/treeview implementation (#38)

* Half of treeview refactor

* Finished treeview

* Removed unnecesary btn class and fixed treeview icons position

* Removed unnecesary treeview component

* Removed outline as David Claux did to match he's style

* Mantained folded state when needed

* Removed unnecesary console.log

* Removed unnecesary icons (#39)

* Fix/minor microsoft pr changes (#40)

* Removed unnecesary icons

* Removed blank line

* Fix/phase 0 (#41)

* Changed aside panel background's color

* Maded JSON togglable

* Refactored CSS

* Fixed PR comments

* Fix/phase 0 (#43)

* Changed aside panel background's color

* Maded JSON togglable

* Refactored CSS

* Fixed PR comments

* Removed unnecesary code

* Fix/json overflow (#46)

* Fixed JSON title width

* Moved to HTML monaco-editor's nav-title

* Fixed toggle class implementation when updatingLayout in the treeview

* Fixed aside scrollbar

* Fixed properties panel label's width

* Fixed JSON panel height when toggled

* Fixed properties panel paddings and FactSet padding-right and padding-left

* Fixed treeview background-color

* Resolved Microsoft/Master into fix/develop merge conflicts (#49)

* Add MSC directive to prevent cppcorecheck build failures on non-VS builds (#1552)

* cleaned up exception handling in loading image (#1526)

* Enable member init checks and fix errors (#1566)

* A class with only static methods and no state should just be a namespace. (#1567)

* Support OnParseAction Handler (#1570)

* Honour preexpandSingleShowCardAction and weight of fact title from HostConfig

* Addressed comments

* Support OnParseAction

* resolved minor comments

* Jwoo/ios render sync (#1547)

* make rendering to be syncronoush by default

* updated custom textblock renderer

* changes before CR

* CR update

* CR update

* [.NET] Prevent async exceptions from tearing down the process (#1561)

* Prevent unobserved exceptions from taking down the process.

If rendering fails, report the error but do not throw on a background thread.

* Add configuration to sign nuget packages

* fixed dll/project names in comments

* Fix actions parent not being set before actions are parsed (#1573)

* Replace ContainerStyle string enum with class + static fields

* Update default card

* Improve hover behavior for Image with selectAction

* Finalize support for width/height in Image and Column

* Add support for icons on action buttons

* Cleanup

* Fix handling of buttons without title

* Fix broken preExpandSingleShowCardAction handling

* Fix actions parent not being set before actions are parsed

* Enable const cppcore checks and fix fallout (#1575)

* Add Events for media play and end (#1546)

* [Android] Add vertical stretch property (#1525)

* Add vertical stretch to android

* Remove non related test file

* Fix comments in FactSetRendered

* Add tests as linked tests

* Update tests results from TestApp with new tests

* Jwoo/ios makrdown optimized (#1554)

* make rendering to be syncronoush by default

* updated custom textblock renderer

* optimized use of html rendering

* fixed factset issue

* fixed build compatability issues below iOS 11.3

* fixes before CR

* CR comments fix

* Added additional headers to public lis in framework. (#1562)

* make rendering to be syncronoush by default

* updated custom textblock renderer

* optimized use of html rendering

* fixed factset issue

* made headers public for customizing buttons

* added ACRUILable.h

* reverted wrong merge

* Enable CPPCORECHECK_DECLARATION_WARNINGS and fix errors (#1579)

* Enable Declaration warnings and first round of fixes

* Clean up remaining unnamed objects warnings and disable C26426 in enums.cpp

* added ability to scroll when there are more buttons than viewing area (#1581)

* make rendering to be syncronoush by default

* updated custom textblock renderer

* optimized use of html rendering

* fixed factset issue

* fixed build compatability issues below iOS 11.3

* fixes before CR

* added UIScrollView to ActionSet

* edits before CR

* Added sample json and updates b4 CR

* Enable "rule of five" checker, fix errors (#1585)

* Add Teams containers (#1469)

Add support for more properties in property sheet
Add initial support for snippets

* [iOS] Add vertical stretch support (#1584)

* Add vertical stretch to android

* make rendering to be syncronoush by default

* updated custom textblock renderer

* optimized use of html rendering

* fixed factset issue

* Remove non related test file

* Fix comments in FactSetRendered

* Add tests as linked tests

* Update tests results from TestApp with new tests

* Add vertical stretch for items

* Remove 'changes' from merge

* Add vertical stretch tests to solution

* Fix issue for image in columnsets rendering

* Fix issue for images being shorter than other columns in columnset

* Keep alignment leading for cards with no stretchable items

* Add new test for auto size image

* Enable all cppcorecheck class warnings and fix errors (#1601)

* Enable override checker and fix errors

* Enable function hiding warning and fix errors

* Enable all class warnings and fix errors

* [iOS] Add missing test for Vertical Stretch (#1603)

* Add missing test

* Fix spaces in json

* Update GetResource method to include type and to support media   (#1583)

* Update get resource method to include type and to support media

* Handle opening media via resource resolver when play is pressed (#1586)

Handle opening media via resource resolver when play is pressed

* Enable unit test code coverage in Debug Win32 builds (#1611)

* Test source file updates (#1551)

* Test file updates

* Jwoo/ios custom styling (#1474)

* XIB first commit

* fixes merge error

* updated InputView with XIB

updated the style of UIButtons

 added UITableViewCell xib for compact mode

removed comments

* code clean up

* added ACRbutton.xib

* Added Xib for CompactCell

* added ACRButton.xib

* allowed column with numeric width value to stretch (#1595)

* allowed column with numeric width value to stretch

* fix merge and remove spacing for the first item

* [UWP][Android][iOS] Add aesthetic fix Icons in Actions (#1612)

* Add aesthetic fix to UWP

* Aesthetic fix for android

* Aesthetic fix for iOS

* Add json test files to project

* Fix formatting

* updated showcard rendering position (#1600)

removed comments

* compact style choice set "make choice" row will reflect user choice (#1596)

* in progress

* when user chooses, user choice will be shown

* updated default message

* value is used instead of "Make Choice"

* handles cases where compact style lacking defaults (#1627)

* fixed separator issue (#1629)

* Remove Stretch from vertical content alignment (#1630)

* Jwoo/explicit image size ios (#1374)

* explicit image changes

* Added 'Explicit' enum value

* uwp changes

* uwp changes

* added explicit image sizing option for ios

* removed division

* fixes extra spacing issue in UICollectionView (#1628)

* fixes extra spacing issue in UICollectionView

* refined intrinsic content size for collection view

* fixed precision error

* fixes url loading sync issue for actions (#1641)

* fixes url loading sync issue for actions

removed hard coded image icon placement

* fixed indentation and changed variable name

* Fix media controls (#1614)

* [TS] Fixed Input.Text style and horizontalAlignment roundtrip; added test (#1636)

* Input.Text roundtrip, added test and fix

* feedback -vertical spaces

* Change private for protected in all Renderers constructors (#1649)

* Add vertical scroll support (#1650)

* Jwoo/ios custom background image loader (#1642)

* fixes url loading sync issue for actions

removed hard coded image icon placement

* allows custom BG IMG renderer

* Added CustomImageRenderer to sample

* removed CoreGraphics framework as it's not used

* added a test to ensure Unicode/Emoji support (#1647)

:shipit:

* multiline input and input limit for textview and textfield (#1643)

* initial commit for multiline input and input limit

implmt plc hld txt; rmved max len chg when not set

reverted json files

* Refactoring and code clean-up

* updated whitespaces

* Fixed newline char

* [Android] Refocus when a show card changes visibility (#1651)

* Refocus on show card

* Set focus for cards instead of input fields

* Revert "[Android] Refocus when a show card changes visibility (#1651)" (#1653)

This reverts commit f2a899a17eb686a42debb39dd1ac876ab8a3b629.

* changed toggle view to UISwitch (#1631)

* changed toggle view to UISwitch

* dev complete

* streamlined selection process

* updated project file & code clean-up

* added sanity check;chd borderstyle;corner radius

* [Android] Refocus when a show card changes visibility (#1654)

* Refocus on show card

* Set focus for cards instead of input fields

* Fix activity retrieval

* Fix formatting and null check

* [Android] Add custom renderer for actions and actionlayouts (#1655)

* Add functions to register action renderer

* Add IActionLayoutRenderer to support full actionLayout modification

* Fix PR commentsa

* 52619-to-much-padding-in-tree-view

* 52614-tree-view-is-very-messy-as-it-is-resized-to-limited-width

* [Android] Custom image downloading fix (#1666)

* Add overrideable method loadOnlineImage to allow image loading modification

* Fix merge errors

* Fix styling for images

* bitCode added (#1674)

* priority update for factset title (#1670)

* added explicit column width for ios (#1672)

* Reverted to Fabric UI instead of SVGs (#33)

* Reverted to Fabric UI instead of SVGs

* Removed unnecesary comments

* Removed unnecesary CSS and duplicated one (#35)

* Fix bug in XceedNumberInput.Render (#1679)

XceedNumberInput.Render was setting numberPicker.Minimum to input.Max.  This fixes it to set numberPicker.Maximum instead.

* Add a GitHub issue template (#1678)

* Add a GitHub issue template

* Add some more questions to issue template

* Updates to CONTRIBUTING.md

- Don't tell people to use the Schema label since non-contributors can't use labels
- Eliminate some early preview wording
- Fix some links

* Direct questions to StackOverflow

* Fix/use hostconfig to add container styles (#36)

* background fix

* Added background color via CSS again

* Fixed some colours

* Fixed class names in CSS and HTML

* Moved interfaz to separate component

* Fixed action and add column styles

* Reverted removed commented code

* Removed CSS properties panel color modification

* Changed querySelector by getElementById

* Removed commented code

* [Android] Fix for vertical scroll in input text (#1689)

* Add touchlistener for vertical scroll in input text

* Fix styling

* Jwoo/variablenumoflines choiceset (#1687)

* updated content sz calcuation logic for inputview

* Updated Toggle Switch Style

* inputView refinements

* added ACRDateTextField

* disable custom background image loading

* fixes line clipping issue of toggle switch

* costmetic changes before CR

* CR changes

* Fix/hostconfig styles (#37)

* Changed SVGs to FabriUI Font

* Changed SVGs to FabriUI Font

* Changed aside-panel icons when folded

* Added cursor pointer to panel headers and avoided user-select it's text

* Added cursor pointer to properties/treewview panels when folded

* Added treeview icon fonts from FabricUI instead of SVGs

* Fixed treeview icons positon

* Fix/treeview implementation (#38)

* Half of treeview refactor

* Finished treeview

* Removed unnecesary btn class and fixed treeview icons position

* Removed unnecesary treeview component

* Removed outline as David Claux did to match he's style

* Mantained folded state when needed

* Removed unnecesary console.log

* Removed unnecesary icons (#39)

* Increase the information in the version error message  (#1697)

Increase the information in the error message when version fails to parse, and mark version as required in order to get a more specific error message

* Fix/minor microsoft pr changes (#40)

* Removed unnecesary icons

* Removed blank line

* Fix/phase 0 (#41)

* Changed aside panel background's color

* Maded JSON togglable

* Refactored CSS

* Fixed PR comments

* Reverse backwards if to allow image tracking (#1700)

* Fix/phase 0 (#43)

* Changed aside panel background's color

* Maded JSON togglable

* Refactored CSS

* Fixed PR comments

* Removed unnecesary code

* Fix/json overflow (#46)

* Fixed JSON title width

* Moved to HTML monaco-editor's nav-title

* Fixed toggle class implementation when updatingLayout in the treeview

* Fixed aside scrollbar

* Fixed properties panel label's width

* Fixed JSON panel height when toggled

* Fixed properties panel paddings and FactSet padding-right and padding-left

* Fixed treeview background-color

* [CPP] Fix/cpp small fixes (#1681)

* this was breaking the build on case-sensitive FS

* lesser evil (no autosave); better to ignore the file, methinks

* removed unused

* reordered

* Revert "removed unused" since ES.84

This reverts commit c403517575dd7c1b26e26ff4b8ff4af695988497.

* reordered

* Set AutomationProperties.Name to AltText on Images (#1701)

* added resource resolver (#1702)

* added resource resolver

* Added resource resolver class

* Added interface file

* chged NSString to NSURL as arg to the resolver IF

* Media event changes (#1712)

* Fixes UI Issues (#1709)

* Minor UI fixes

* chececk pointer against boolVal message

* removed extra method call

* Move category to DesignerPeerRegistration

* Icons in tree view, bug fixes and more. Work in progress.

* Rework full screen handler to add relayout when full screen is toggled
Minr changes
Work still in progress

* Add one file missed with last commit

* More massaging
Still work in progress

* Restore side pane expand/collapse. Now generic and supports more than 2

* Minor CSS tweak to vertically center side pane header content

* Address some bug bash feedback
Plus minor bug fixes

* Minor tweak

* Fix side panes losing scrollbar after being collapsed and expanded

* Fix designer dying when removing an action after ShowCard was expanded

* Add support for inplace editors
Add TextBlock inplace editor

* Add support for undo/redo

* CSS tweak

* Another CSS tweak

* Cleanup

* Save side panes size and expanded state to local storage

* Small fix

* Fix regression: action button are not being updated
Add support for iconUrl

* Fix container styles not being applied correctly in deep hierarchies
  • Loading branch information
dclaux authored Aug 9, 2018
1 parent 180d4a4 commit 6bb080d
Showing 1 changed file with 11 additions and 9 deletions.
20 changes: 11 additions & 9 deletions source/nodejs/adaptivecards/src/card-elements.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2292,9 +2292,7 @@ class ActionButton {
constructor(action: Action, parentContainerStyle: string) {
this.action = action;
this._parentContainerStyle = parentContainerStyle;
}

initialize() {
this.action.render();
this.action.renderedElement.onclick = (e) => { this.click(); };

Expand Down Expand Up @@ -3105,16 +3103,14 @@ class ActionCollection {

if (!actionButton) {
actionButton = new ActionButton(this.items[i], parentContainerStyle);
actionButton.action.renderedElement.style.overflow = "hidden";
actionButton.action.renderedElement.style.overflow = "table-cell";
actionButton.action.renderedElement.style.flex = this._owner.hostConfig.actions.actionAlignment === Enums.ActionAlignment.Stretch ? "0 1 100%" : "0 1 auto";
actionButton.onClick = (ab) => { this.actionClicked(ab); };

this.buttons.push(actionButton);
}

actionButton.initialize();
actionButton.action.renderedElement.style.overflow = "hidden";
actionButton.action.renderedElement.style.overflow = "table-cell";
actionButton.action.renderedElement.style.flex = this._owner.hostConfig.actions.actionAlignment === Enums.ActionAlignment.Stretch ? "0 1 100%" : "0 1 auto";
actionButton.onClick = (ab) => { this.actionClicked(ab); };

buttonStrip.appendChild(actionButton.action.renderedElement);

this._renderedActionCount++;
Expand Down Expand Up @@ -4033,7 +4029,13 @@ export class Container extends CardElementContainer {

get style(): string {
if (this.allowCustomStyle) {
return this._style && this.hostConfig.containerStyles.getStyleByName(this._style) ? this._style : this.defaultStyle;
if (this._style && this.hostConfig.containerStyles.getStyleByName(this._style)) {
return this._style;
}

let parentContainer = this.getParentContainer();

return parentContainer ? parentContainer.style : this.defaultStyle;
}
else {
return this.defaultStyle;
Expand Down

0 comments on commit 6bb080d

Please sign in to comment.