Salesperson API #27664
Open
Salesperson API #27664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbuyuka
reviewed
Nov 21, 2024
| { | ||
| Caption = 'Name'; | ||
| } | ||
| field(eMail; Rec."E-Mail") |
There was a problem hiding this comment.
Suggested change
| field(eMail; Rec."E-Mail") | |
| field(email; Rec."E-Mail") |
|
For tests, you need to use Isolation Disabled test runner codeunit to run them in a container |
onbuyuka
reviewed
Nov 21, 2024
| @@ -0,0 +1,122 @@ | |||
| codeunit 139870 "APIV2 - Salesperson/Purch E2E" | |||
There was a problem hiding this comment.
It'd be great to add an Update test too
pri-kise
suggested changes
Nov 21, 2024
| LibraryUtility: Codeunit "Library - Utility"; | ||
| IsInitialized: Boolean; | ||
| EmptyJSONErr: Label 'JSON should not be empty.'; | ||
| ServiceNameTxt: Label 'salespeoplePurchasers'; |
There was a problem hiding this comment.
This lable should be locked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A new API page for Salespeople/Purchasers
I created the tests in a similar manner that I found suitable for Locations, but I did not manage to run the test. Thus, looking forward to the feedback if tests do pass in Microsoft Pipelines or how to test those calls in a container. Currently I do not have a clue how to do it.
Work Item(s)
Fixes #26806
Fixes AB#541735