Shopify Connector Tax ID, Multiple Company Locations, Tax ID export, Company Mapping by Tax ID, Payment Terms Export/Import, Company External ID #27577

GediminasGaubys · 2024-10-31T10:36:27Z

This pull request does not have a related issue as it's part of the delivery for development agreed directly with @AndreiPanko

Implementation 1 (Customer No. in Shopify Catalogs)

New functionality has been added to assign 'Customer No.' in Shopify Catalogs during Customer as Company export.

Implementation 2 (Import of Multiple Company Locations)

New functionality has been added that stores all Company Locations during import from Shopify. The first Company Location in the response is marked as 'Default'. To receive all Company Locations instead of one, new Query 'Shpfy GQL CompLocations' has been created. And Locations part has been removed from 'Shpfy GQL Company' query.
During the Customer as Company export, new created Shopify Company Location is marked as 'Default'.
Additionally Company Locations page was created to be able to see information from Business Central side. Company Locations page can be opened from Shopify Companies and Shopify Company Card pages.

Implementation 3 (Tax ID export and Company/Customer mapping by Tax Id)

Tax ID export to Shopify - Added functionality to update Tax Id on Company Creation and Synchronization (new GraphQL 'companyLocationCreateTaxRegistration' created and extended GraphQL 'companyCreate' by including Tax ID). Which Customer field has to be used as Tax Id is determined by field 'Company Tax Id Mapping' value on 'Shopify Shop Card'. There are 2 possible options: 'Registration Number' and 'VAT Registration No.'. Enum is extensible, so that user could add any other option to which fields Tax ID has to be linked (implementation codeunit has to be created and linked to new Enum value).
Company/Customer mapping by Tax Id - The logic how Company is linked to customer has to be mapped (by email/phone, by tax id, default company) is defined on 'Company Mapping Type' field on 'Shopify Shop Card' page. The 'Company Mapping Type' enum value has to be linked with implementation codeunits that are doing actual Company/Customer mapping. The changes that has been made:

Interface "Shpfy ICompany Mapping" has been extended by creating new interface 'Shpfy IFind Company Mapping' that has new procedure FindMapping()
Moved Existing Mapping by email/phone logic to implementation codeunit
Added new functionality to implementation codeunit for 'Default Company' selection
Created new implementation codeunit to do mapping by Tax ID
Updated existing code by implementing 'Type testing and casting operators for interfaces - 'is' 'as' '. This functionality identifies if implementation codeunit has new interface 'Shpfy IFind Company Mapping' implemented. If so - 'FindMapping' procedure is executed, if not - mapping using email/phone is used as default option.

Implementation 4 (Company Location Payment Terms Export/Import)

Company Location Payment Terms Export - new GraphQL implementation codeunit for 'Shpfy GraphQL Type' has been created which allows to send Payment Terms to Shopify. If mapped value for Customer Payment Terms Code exist in 'Payment Terms Mapping', Shopify Payment Terms ID is exported to Shopify for that Company/Customer.
Company Location Payment Terms Import - GraphQL 'Shpfy GQL Company' that retrieves Company information from Shopify has been updated by adding new field 'paymentTermsTemplate'. If During the import the mapping in 'Payment Terms Mapping' exist, the Customer in BC is updated by the Payment Terms from Shopify.

Implementation 5 (Populate External ID during the export customer as a company)

Existing GraphQL that creates new Companies in Shopify has been updated by adding new field 'externalId'. The value which is 'Customer No.'

…as Company export

…onal action to open Company Locations

…ements

… for Company Locations

…pping

github-actions · 2024-10-31T10:36:48Z

Could not find linked issues in the pull request description. Please make sure the pull request description contains a line that contains 'Fixes #' followed by the issue number being fixed. Use that pattern for every issue you want to link.

onbuyuka · 2024-11-06T12:35:38Z

Apps/W1/Shopify/app/src/Catalogs/Pages/ShpfyCatalogs.Page.al

@@ -28,7 +28,7 @@ page 30159 "Shpfy Catalogs"
                field("Customer No."; Rec."Customer No.")
                {
                    ApplicationArea = All;
-                    Visible = false;
+                    Editable = false;


@AndreiPanko this means each catalog will be assigned a customer and only that customer will be used to calculate the price. Not the settings in the catalogs page. ("Customer Price Group", "Customer Disc. Group", "Allow Line Disc.")

Is that the intention? Then shouldn't we remove those settings from the page?

onbuyuka · 2024-11-06T12:37:25Z

Apps/W1/Shopify/app/src/Companies/Tables/ShpfyCompanyLocation.Table.al

+        }
+        field(14; "Shpfy Payment Terms Id"; BigInteger)
+        {
+            Caption = 'Shpfy Payment Terms Id';


Suggested change

Caption = 'Shpfy Payment Terms Id';

Caption = 'Shopify Payment Terms Id';

onbuyuka · 2024-11-06T12:40:57Z

Apps/W1/Shopify/app/src/Companies/Codeunits/ShpfyCompanyMapping.Codeunit.al

-        ShopifyCustomer: Record "Shpfy Customer";
-        CustomerMapping: Codeunit "Shpfy Customer Mapping";
-        PhoneFilter: Text;
+        ShpfyCompByEmailPhone: Codeunit "Shpfy Comp. By Email/Phone";


Please fix the variable naming.

If same name exists in Base Application then Shopify prefix, otherwise no prefix.

Example:

ShopifyCustomer: Record "Shpfy Customer" -> customer exists in Base Application
Catalog: Record "Shpfy Catalog" -> catalog does not exist in Base Application

onbuyuka · 2024-11-06T12:41:32Z

Apps/W1/Shopify/app/src/Companies/Codeunits/ShpfyCompanyExport.Codeunit.al

@@ -199,4 +208,16 @@ codeunit 30284 "Shpfy Company Export"
    begin
        CreateCustomers := NewCustomers;
    end;
+
+    local procedure GetShpfyPaymentTermsIdFromCustomer(Customer: Record Customer; var ShpfyPaymentTermsId: BigInteger): Boolean


There's no need to use Shpfy in the procedure names. Just use Shopify

onbuyuka · 2024-11-06T12:45:01Z

Have you considered upgrade scenarios? What will happen for already imported companies? How will locations sync in that case?

petemchlk · 2024-11-13T12:37:15Z

@onbuyuka resolved your comments about the naming issues

Regarding upgrade - it updates the locations well when you Sync Companies, but the problem is that update happens only if Company was updated on the date later than Last Synchronization for Shopify Companies. So, if somebody has old version and multiple location existing and had not updated company in Shopify in meantime won't get these updated locations in BC.

Since this is how the Company Sync. worked before is this correct behavior?

jzaksauskas and others added 29 commits September 30, 2024 16:14

1 task. Customer No. assignment for Shopify Catalogs during Customer …

299bb82

…as Company export

2 task. Import Multiple Company locations to Business Central. Additi…

b9b6462

…onal action to open Company Locations

2 task. Import Multiple Company locations to Business Central. Improv…

bf343d5

…ements

3 task. Tax ID export/mapping

00b9c65

5 task. Assign External ID during Csutomer as Company export

51cae44

Set Company Location as default on Shopify Company creation

8cbb245

Get Tax Registration Number moved to implementation codeunits

ee27f39

Moved Company Mapping to implementation codeunits

accc09a

Implemented Export and Import for Company Location Payment Terms

2e90b5d

Re-implemented logic to get Graph queries to Interfces

7916a9e

Fixes after PR review

a3491c0

Changes after PR review

8ca4d53

Created new interface to avoid destructive change. Created pagination…

17c2f51

… for Company Locations

Removed locations from GetCompany graphQL

df63786

Extending the compnay mapping interface

c7f8822

removed implemenetions from enum for new interface

497976b

test commit

64b60e6

remove empty line

52426d1

fix existing test, add test for catalog

e217b4d

Task 1 test

ca3dd8c

add find mapping tests

b779120

add tests

2ba709b

Payment terms integration tests, fix create customer Payment terms ma…

bc4d15d

…pping

TaxID and Payment Terms export tests

d86daa5

Add external id export test

853e713

refactor

6e07369

refactor

edc6480

fix test

da05306

Minor adjustment

58bbf66

GediminasGaubys requested a review from a team as a code owner October 31, 2024 10:36

GediminasGaubys requested a review from EvgenijKorovin October 31, 2024 10:36

JesperSchulz added the Integration GitHub request for Integration area label Nov 1, 2024

onbuyuka reviewed Nov 6, 2024

View reviewed changes

petemchlk added 4 commits November 12, 2024 14:03

fix naming

f4dc384

Merge branch 'main' into taxid_minorchanges_withunittests

34476e2

remove duplicated object

f6c0c19

fix issue with default location

d5e6fad

change clear to init

b6e00ce

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Shopify Connector Tax ID, Multiple Company Locations, Tax ID export, Company Mapping by Tax ID, Payment Terms Export/Import, Company External ID #27577

Shopify Connector Tax ID, Multiple Company Locations, Tax ID export, Company Mapping by Tax ID, Payment Terms Export/Import, Company External ID #27577

GediminasGaubys commented Oct 31, 2024

github-actions bot commented Oct 31, 2024

onbuyuka Nov 6, 2024

onbuyuka Nov 6, 2024

onbuyuka Nov 6, 2024

onbuyuka Nov 6, 2024

onbuyuka commented Nov 6, 2024

petemchlk commented Nov 13, 2024

	Caption = 'Shpfy Payment Terms Id';
	Caption = 'Shopify Payment Terms Id';

Shopify Connector Tax ID, Multiple Company Locations, Tax ID export, Company Mapping by Tax ID, Payment Terms Export/Import, Company External ID #27577

Are you sure you want to change the base?

Shopify Connector Tax ID, Multiple Company Locations, Tax ID export, Company Mapping by Tax ID, Payment Terms Export/Import, Company External ID #27577

Conversation

GediminasGaubys commented Oct 31, 2024

github-actions bot commented Oct 31, 2024

onbuyuka Nov 6, 2024

Choose a reason for hiding this comment

onbuyuka Nov 6, 2024

Choose a reason for hiding this comment

onbuyuka Nov 6, 2024

Choose a reason for hiding this comment

onbuyuka Nov 6, 2024

Choose a reason for hiding this comment

onbuyuka commented Nov 6, 2024

petemchlk commented Nov 13, 2024