[E-Document Connector] Logiq E-Document Connector #27562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tstefanovicius
requested review from
Groenbech96,
WaelAbuSeada and
aholstrup1
as code owners
|
@microsoft-github-policy-service agree company="Companial" |
tstefanovicius
changed the title
|
New pull request instead of #27101 |
|
Thanks for fixing the issue.
Feel free to look at Avalara as the example. In the mean time we will start looking at the code. |
Groenbech96
requested changes
Nov 1, 2024
|
|
||
| enum 6380 "Logiq API Engine" | ||
| { | ||
| Extensible = false; |
| @@ -0,0 +1,19 @@ | |||
| namespace Microsoft.EServices.EDocumentConnector.Logiq; | |||
|
|
|||
| enum 6380 "Logiq API Engine" | |||
| @@ -0,0 +1,182 @@ | |||
| namespace Microsoft.EServices.EDocumentConnector.Logiq; | |||
|
|
|||
| codeunit 6380 "Logiq Auth" | |||
There was a problem hiding this comment.
Please move the code to EDocumentConnectors
Create app for the connector.
Create app for the test automation.
Feel free to look at Avalara as the example.
In the mean time we will start looking at the code.
| ResponseMessage: HttpResponseMessage; | ||
| AccessToken, RefreshToken : SecretText; | ||
| AccessTokExpires, RefreshTokExpires : DateTime; | ||
| AuthenticationFailedErr: Label 'Logiq authentication failed. Please check the user credentials.'; |
There was a problem hiding this comment.
Labels needs to be on global var.
|
|
||
| internal procedure CheckUserCredentials(var LogiqConnectionUserSetup: Record "Logiq Connection User Setup") | ||
| var | ||
| NoSetupErr: Label 'No user setup found. Please fill the user setup in the Logiq Connection User Setup page.'; |
|
|
||
| page 6380 "Logiq Connection Setup" | ||
| { | ||
| Caption = 'E-Document External Connection Setup'; |
There was a problem hiding this comment.
Different name. Use connector name
| DataClassification = CustomerContent; | ||
| fields | ||
| { | ||
| field(1; PK; Code[10]) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E-Documents connector interface implementation between Business Central and Logiq
Work Item(s)
Fixes #27058
Fixes AB#541809