[Shopify] Customer/Company Metafields #27542

tinestaric · 2024-10-25T08:58:55Z

This pull request does not have a related issue as it's part of delivery for development agreed directly with @AndreiPanko
Fixes #26819

Existing metafield engine applied to integrate Customer and Company metafields

Changes done to apply the engine:

Extended ShpfyGQLCompany.Codeunit.al and ShpfyGQLCustomer.Codeunit.al GQL query to get metafields with required properties in response. Removed the namespace from query to retreive all metafields.
Created 2 new GraphQL queries Shpfy GQL CustomerMetafieldIds and Shpfy GQL CompanyMetafieldIds to make RetrieveMetafieldsFromShopify function work with Company and Customer.
Created 2 new IMetafield Owner Type implementation codeunits for Company and Customer
Added values to related interface enums
Added UpdateMetafield functions in API codeunits to update metafields if there are metafields in response
Removed old not working code to update metafields
Add Metafields actions to Company/Customer list and card pages.
Add owner type Company to GetOwnerType procedure in Shpfy Metafield table
Changed parameters in CollectMetafieldIds local procedure in Shpfy Metafield API codeunit to support all Ownet types in function

Fixes AB#556298

…tomer metafields in shopify

onbuyuka · 2024-10-27T15:40:37Z

Apps/W1/Shopify/app/src/Companies/Pages/ShpfyCompanies.Page.al

+                PromotedCategory = Process;
+                PromotedIsBig = true;
+                PromotedOnly = true;
+                ToolTip = 'Add metafields to a product. This can be used for adding custom data fields to products in Shopify.';


Suggested change

ToolTip = 'Add metafields to a product. This can be used for adding custom data fields to products in Shopify.';

ToolTip = 'Add metafields to a company. This can be used for adding custom data fields to products in Shopify.';

onbuyuka · 2024-10-27T15:40:52Z

Apps/W1/Shopify/app/src/Companies/Pages/ShpfyCompanyCard.Page.al

+                PromotedCategory = Category4;
+                PromotedIsBig = true;
+                PromotedOnly = true;
+                ToolTip = 'Add metafields to a product. This can be used for adding custom data fields to products in Shopify.';


Suggested change

ToolTip = 'Add metafields to a product. This can be used for adding custom data fields to products in Shopify.';

ToolTip = 'Add metafields to a company. This can be used for adding custom data fields to products in Shopify.';

onbuyuka · 2024-10-27T15:41:37Z

Apps/W1/Shopify/app/src/Customers/Pages/ShpfyCustomerCard.Page.al

+                PromotedCategory = Category4;
+                PromotedIsBig = true;
+                PromotedOnly = true;
+                ToolTip = 'Add metafields to a product. This can be used for adding custom data fields to products in Shopify.';


Suggested change

ToolTip = 'Add metafields to a product. This can be used for adding custom data fields to products in Shopify.';

ToolTip = 'Add metafields to a customer. This can be used for adding custom data fields to products in Shopify.';

onbuyuka · 2024-10-27T15:42:58Z

Apps/W1/Shopify/app/src/Customers/Pages/ShpfyCustomers.Page.al

+                PromotedCategory = Process;
+                PromotedIsBig = true;
+                PromotedOnly = true;
+                ToolTip = 'Add metafields to a product. This can be used for adding custom data fields to products in Shopify.';


Suggested change

ToolTip = 'Add metafields to a product. This can be used for adding custom data fields to products in Shopify.';

ToolTip = 'Add metafields to a customer. This can be used for adding custom data fields to products in Shopify.';

JesperSchulz · 2024-10-30T15:47:43Z

Had to fix ID clashes:
30313->30366
139621->139541
139622->139543
139623->139548
139624->139549
139625->139547

JesperSchulz · 2024-10-31T08:37:52Z

@tinestaric, could you update the objects IDs as stated above? You will also need to update the app.json of the test app, by adding the following range:
{
"from": 139541,
"to": 139549
}

When done, I'll merge this PR.

petemchlk · 2024-10-31T12:04:03Z

Added additional requirements to edit Metafields. In case of import AllCompanies and AllCustomers metafields would be overwritten with values from Shopify before it would be exported.

JesperSchulz · 2024-10-31T12:18:29Z

@petemchlk, I've already processed this PR internally. Your most recent changes won't be part of this PR 😟 Could you maybe create a new PR for that, once this one is merged? But for this to become merged, I need you to update the ID as instructed above.

petemchlk · 2024-10-31T12:45:02Z

@JesperSchulz updated IDs, should I remove these additional changes?

JesperSchulz · 2024-11-01T09:28:48Z

@JesperSchulz updated IDs, should I remove these additional changes?

No, I'll merge them in. Looks like it's a rather limited change 😊

JesperSchulz · 2024-11-01T10:09:57Z

@JesperSchulz updated IDs, should I remove these additional changes?

No, I'll merge them in. Looks like it's a rather limited change 😊

@petemchlk, you may see that your last changes shortly disappear from this repo again, as we're force syncing the repo code with a version, which doesn't yet contains your last changes. But don't worry, they will be back in a later sync 😊

petemchlk · 2024-11-04T08:23:00Z

@JesperSchulz updated IDs, should I remove these additional changes?

No, I'll merge them in. Looks like it's a rather limited change 😊

@petemchlk, you may see that your last changes shortly disappear from this repo again, as we're force syncing the repo code with a version, which doesn't yet contains your last changes. But don't worry, they will be back in a later sync 😊

@JesperSchulz thanks! so no need to create additional PR?

JesperSchulz · 2024-11-04T09:33:20Z

@JesperSchulz updated IDs, should I remove these additional changes?

No, I'll merge them in. Looks like it's a rather limited change 😊

@petemchlk, you may see that your last changes shortly disappear from this repo again, as we're force syncing the repo code with a version, which doesn't yet contains your last changes. But don't worry, they will be back in a later sync 😊

@JesperSchulz thanks! so no need to create additional PR?

Nope, all done 😊

petemchlk added 21 commits October 3, 2024 18:30

add import customer metafields import

b4b8323

handle metafields removalwhen removed in Shopify

641b9b6

remove old metafield related not working code, add code to update Cus…

2e391ee

…tomer metafields in shopify

add company metafield import

ddf0b67

Add metafield export support

753ab0c

small refactors

321fd5e

add metafields action to customer/company card

56a224d

create test cu

878d2ed

create test codeunit

ce08405

add test

38d4e03

add comany tests, create helper codeunit

9e97378

Merge branch 'main' into dev/pmi/CustomerMetafields

bf65b47

remove empty spaces

cc72822

pr fix, add page editable function to metafield owner interface

abf978e

change procedure name and summary

33dee95

renumber objects

cfb0302

sending metafields test in progress

b86173d

refactor export metafields test

7ae9575

add company export metafields test

6175567

renumber ids

bdbdac2

updated return var documentation

f316da3

tinestaric requested a review from a team as a code owner October 25, 2024 08:58

tinestaric requested a review from onbuyuka October 25, 2024 08:58

JesperSchulz added the Integration GitHub request for Integration area label Oct 25, 2024

JesperSchulz assigned onbuyuka Oct 25, 2024

onbuyuka reviewed Oct 27, 2024

View reviewed changes

fix object id

92c49c3

fix tooltips

8484fd2

onbuyuka previously approved these changes Oct 30, 2024

View reviewed changes

JesperSchulz added the linked Issue is linked to a Azure Boards work item label Oct 30, 2024

JesperSchulz self-assigned this Oct 30, 2024

JesperSchulz added the processing-PR The PR is currently being reviewed label Oct 30, 2024

make metafields only edaitable when not imported before export

0594f9a

petemchlk dismissed onbuyuka’s stale review via 0594f9a October 31, 2024 11:58

object id fixes

36ca70d

aholstrup1 merged commit fe1fe17 into microsoft:main Nov 1, 2024
6 of 8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Shopify] Customer/Company Metafields #27542

[Shopify] Customer/Company Metafields #27542

tinestaric commented Oct 25, 2024 •

edited by github-actions bot

Loading

onbuyuka Oct 27, 2024

onbuyuka Oct 27, 2024

onbuyuka Oct 27, 2024

onbuyuka Oct 27, 2024

JesperSchulz commented Oct 30, 2024

JesperSchulz commented Oct 31, 2024

petemchlk commented Oct 31, 2024

JesperSchulz commented Oct 31, 2024

petemchlk commented Oct 31, 2024

JesperSchulz commented Nov 1, 2024

JesperSchulz commented Nov 1, 2024

petemchlk commented Nov 4, 2024

JesperSchulz commented Nov 4, 2024

	ToolTip = 'Add metafields to a product. This can be used for adding custom data fields to products in Shopify.';
	ToolTip = 'Add metafields to a company. This can be used for adding custom data fields to products in Shopify.';

	ToolTip = 'Add metafields to a product. This can be used for adding custom data fields to products in Shopify.';
	ToolTip = 'Add metafields to a customer. This can be used for adding custom data fields to products in Shopify.';

[Shopify] Customer/Company Metafields #27542

[Shopify] Customer/Company Metafields #27542

Conversation

tinestaric commented Oct 25, 2024 • edited by github-actions bot Loading

Existing metafield engine applied to integrate Customer and Company metafields

onbuyuka Oct 27, 2024

Choose a reason for hiding this comment

onbuyuka Oct 27, 2024

Choose a reason for hiding this comment

onbuyuka Oct 27, 2024

Choose a reason for hiding this comment

onbuyuka Oct 27, 2024

Choose a reason for hiding this comment

JesperSchulz commented Oct 30, 2024

JesperSchulz commented Oct 31, 2024

petemchlk commented Oct 31, 2024

JesperSchulz commented Oct 31, 2024

petemchlk commented Oct 31, 2024

JesperSchulz commented Nov 1, 2024

JesperSchulz commented Nov 1, 2024

petemchlk commented Nov 4, 2024

JesperSchulz commented Nov 4, 2024

tinestaric commented Oct 25, 2024 •

edited by github-actions bot

Loading