[E-Document Connector] Continia E-Document Connector #27380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial code commit for Continia Microsoft E-Document Connector
CristianMocanuContinia
requested review from
Groenbech96,
WaelAbuSeada and
aholstrup1
as code owners
|
@microsoft-github-policy-service agree [company="Continia Software A/S"] |
|
@microsoft-github-policy-service agree company="Continia Software A/S" |
AndreasMoth
reviewed
Oct 9, 2024
Apps/W1/EDocumentsConnector/app/src/Continia/API Requests/APIRequests.Codeunit.al
Outdated
Show resolved
Hide resolved
AndreasMoth
reviewed
Oct 9, 2024
Apps/W1/EDocumentsConnector/app/src/Continia/API Requests/APIRequests.Codeunit.al
Outdated
Show resolved
Hide resolved
AndreasMoth
reviewed
Oct 9, 2024
Apps/W1/EDocumentsConnector/app/src/Continia/API Requests/APIRequests.Codeunit.al
Outdated
Show resolved
Hide resolved
AndreasMoth
reviewed
Oct 9, 2024
Apps/W1/EDocumentsConnector/app/src/Continia/Metadata/NetworkProfile.Table.al
Outdated
Show resolved
Hide resolved
AndreasMoth
reviewed
Oct 9, 2024
Apps/W1/EDocumentsConnector/app/src/Continia/Metadata/NetworkProfile.Table.al
Outdated
Show resolved
Hide resolved
AndreasMoth
reviewed
Oct 9, 2024
Apps/W1/EDocumentsConnector/app/src/Continia/Metadata/Network.Enum.al
Outdated
Show resolved
Hide resolved
Code changes based on feedback comments
pri-kise
reviewed
Oct 16, 2024
| { | ||
| Access = Internal; | ||
|
|
||
| [EventSubscriber(ObjectType::Codeunit, Codeunit::"Environment Cleanup", 'OnClearCompanyConfig', '', false, false)] |
There was a problem hiding this comment.
should we really clean the config ony any Environment Cleanup?
Maybe this should only be done, when a production environment is copied to a sandbox environment?
Groenbech96
requested changes
Nov 1, 2024
|
|
||
| enum 6391 "Profile Direction" | ||
| { | ||
| Extensible = false; |
| // ------------------------------------------------------------------------------------------------ | ||
| namespace Microsoft.EServices.EDocumentConnector.Continia; | ||
|
|
||
| table 6394 "Network Profile" |
There was a problem hiding this comment.
Move tooltips from page to table.
| { | ||
| Extensible = false; | ||
|
|
||
| value(0; peppol) |
There was a problem hiding this comment.
Enum internal?
why values with small letters?
|
|
||
| OwnerAzureId := AzureADTenant.GetAadTenantId(); | ||
| if OwnerAzureId = '' then | ||
| OwnerAzureId := 'Common'; |
There was a problem hiding this comment.
Would we not want to fail here?
| if OwnerAzureId = '' then | ||
| OwnerAzureId := 'Common'; | ||
|
|
||
| EnvironmentName := EnvironmentInformation.GetEnvironmentName(); |
| using Microsoft.Foundation.Address; | ||
| using Microsoft.Foundation.Company; | ||
|
|
||
| codeunit 6393 "Api Requests" |
There was a problem hiding this comment.
Move under E-Document Connectors.
- Create app
- Create test app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E-Documents connector interface implementation between Business Central and Continia Delivery Network for onboarding into the Peppol and NemHandel network, sending and receiving electronic documents.
Work Items:
Fixes #27056
Fixes AB#541807