Skip to content

Commit

Permalink
Merge branch 'main' into main
Browse files Browse the repository at this point in the history
  • Loading branch information
plakna authored Oct 8, 2024
2 parents 9f56808 + 1a13eb2 commit 3116518
Show file tree
Hide file tree
Showing 460 changed files with 73,255 additions and 70,171 deletions.
2 changes: 1 addition & 1 deletion .github/AL-Go-Settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"runs-on": "windows-latest",
"cacheImageName": "",
"UsePsSession": false,
"artifact": "https://bcinsider-fvh2ekdjecfjd6gk.b02.azurefd.net/sandbox/26.0.24098.0/base",
"artifact": "https://bcinsider-fvh2ekdjecfjd6gk.b02.azurefd.net/sandbox/26.0.24649.0/base",
"country": "base",
"useProjectDependencies": true,
"repoVersion": "26.0",
Expand Down
19 changes: 0 additions & 19 deletions Apps/CH/SwissQRBill/app/src/SwissQRBillInstall.Codeunit.al
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,6 @@ codeunit 11517 "Swiss QR-Bill Install"
with SwissQRBillSetup do
if IsEmpty() then begin
"Address Type" := "Address Type"::Structured;
#if not CLEAN23
"Umlaut Chars Encode Mode" := "Umlaut Chars Encode Mode"::Double;
#endif
if NewDefaultLayoutCode <> '' then
"Default Layout" := NewDefaultLayoutCode;
InitDefaultJournalSetup();
Expand Down Expand Up @@ -176,9 +173,6 @@ codeunit 11517 "Swiss QR-Bill Install"
if OldSwissQRBillSetup.Get() then begin
SwissQRBillSetup.Init();
SwissQRBillSetup."Address Type" := MapAddressType(OldSwissQRBillSetup."Address Type");
#if not CLEAN23
SwissQRBillSetup."Umlaut Chars Encode Mode" := MapEncodeMode(OldSwissQRBillSetup."Umlaut Chars Encode Mode");
#endif
SwissQRBillSetup."Default Layout" := OldSwissQRBillSetup."Default Layout";
SwissQRBillSetup."Last Used Reference No." := OldSwissQRBillSetup."Last Used Reference No.";
SwissQRBillSetup."Journal Template" := OldSwissQRBillSetup."Journal Template";
Expand Down Expand Up @@ -231,19 +225,6 @@ codeunit 11517 "Swiss QR-Bill Install"
exit(SwissQRBillAddressType::Combined);
end;
end;
#if not CLEAN23
local procedure MapEncodeMode(EncodeMode: Option Single,Double,Remove) SwissQRBillUmlautEncoding: Enum "Swiss QR-Bill Umlaut Encoding"
begin
case EncodeMode of
EncodeMode::Single:
exit(SwissQRBillUmlautEncoding::Single);
EncodeMode::Double:
exit(SwissQRBillUmlautEncoding::Double);
EncodeMode::Remove:
exit(SwissQRBillUmlautEncoding::Remove);
end;
end;
#endif

local procedure MapIBANType(IBANType: Option IBAN,"QR-IBAN") SwissQRBillIBANType: Enum "Swiss QR-Bill IBAN Type"
begin
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -551,35 +551,6 @@ codeunit 11502 "Swiss QR-Bill Purchases"
Message(MessageResult)
end;

#if not CLEAN23
[EventSubscriber(ObjectType::Codeunit, Codeunit::"Purch.-Post", 'OnBeforePostVendorEntry', '', false, false)]
local procedure OnBeforePostVendorEntry(
var GenJnlLine: Record "Gen. Journal Line";
var PurchHeader: Record "Purchase Header";
var TotalPurchLine: Record "Purchase Line";
var TotalPurchLineLCY: Record "Purchase Line";
PreviewMode: Boolean;
CommitIsSupressed: Boolean;
var GenJnlPostLine: Codeunit "Gen. Jnl.-Post Line")
var
QRBillCurrencyCode: Code[10];
ErrText: Text;
begin
if PurchHeader."Swiss QR-Bill" and (PurchHeader."Prepayment %" = 0) and (PurchHeader."Swiss QR-Bill Amount" <> 0) then begin
QRBillCurrencyCode := SwissQRBillIncomingDoc.GetCurrency(PurchHeader."Swiss QR-Bill Currency");
if PurchHeader."Currency Code" <> QRBillCurrencyCode then begin
ErrText := StrSubstNo(CurrencyErr, QRBillCurrencyCode, PurchHeader."Currency Code");
Error(ErrText);
end;
if Abs(TotalPurchLine."Amount Including VAT") <> PurchHeader."Swiss QR-Bill Amount" then begin
ErrText := StrSubstNo(AmountErr, PurchHeader."Swiss QR-Bill Amount", Abs(TotalPurchLine."Amount Including VAT"));
Error(ErrText);
end;
VoidPurchDocQRBill(PurchHeader);
end;
end;
#endif

[EventSubscriber(ObjectType::Codeunit, Codeunit::"Purch. Post Invoice Events", 'OnPostLedgerEntryOnBeforeGenJnlPostLine', '', false, false)]
local procedure OnPostLedgerEntryOnBeforeGenJnlPostLine(
var GenJnlLine: Record "Gen. Journal Line";
Expand Down
11 changes: 0 additions & 11 deletions Apps/CH/SwissQRBill/app/src/setup/SwissQRBillSetup.Page.al
Original file line number Diff line number Diff line change
Expand Up @@ -35,17 +35,6 @@ page 11514 "Swiss QR-Bill Setup"
ApplicationArea = All;
ToolTip = 'Specifies the address type used for all printed QR-bills. Recommended value is Structured.';
}
#if not CLEAN23
field(UmlautCharsEncodeMode; "Umlaut Chars Encode Mode")
{
ApplicationArea = All;
ToolTip = 'Specifies the German umlaut characters encoding mode. "Single" mode: "Ä" to "A". "Double" mode: "Ä" to "Ae". The recommended value is Double.';
Visible = false;
ObsoleteReason = 'No need to convert umlauts, because encoding was changed to UTF-8.';
ObsoleteState = Pending;
ObsoleteTag = '23.0';
}
#endif
field(DefaultQRBillLayout; "Default Layout")
{
ApplicationArea = All;
Expand Down
5 changes: 0 additions & 5 deletions Apps/CH/SwissQRBill/app/src/setup/SwissQRBillSetup.Table.al
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,8 @@ table 11512 "Swiss QR-Bill Setup"
{
Caption = 'German Umlaut Chars Encoding Mode';
ObsoleteReason = 'No need to convert umlauts, because encoding was changed to UTF-8.';
#if CLEAN23
ObsoleteState = Removed;
ObsoleteTag = '26.0';
#else
ObsoleteState = Pending;
ObsoleteTag = '23.0';
#endif
}
field(8; "Default Layout"; Code[20])
{
Expand Down
12 changes: 0 additions & 12 deletions Apps/CH/SwissQRBill/app/src/setup/SwissQRBillSetupWizard.Page.al
Original file line number Diff line number Diff line change
Expand Up @@ -154,18 +154,6 @@ page 11516 "Swiss QR-Bill Setup Wizard"
ShowMandatory = true;
ToolTip = 'Specifies the address type used for all printed QR-Bills. Recommended value is Structured.';
}
#if not CLEAN23
field(UmlautCharsEncodeMode; "Umlaut Chars Encode Mode")
{
ApplicationArea = All;
ShowMandatory = true;
ToolTip = 'Specifies the German umlaut characters encoding mode. "Single" mode: "Ä" to "A". "Double" mode: "Ä" to "Ae". Recommended value is Double.';
Visible = false;
ObsoleteReason = 'No need to convert umlauts, because encoding was changed to UTF-8.';
ObsoleteState = Pending;
ObsoleteTag = '23.0';
}
#endif
}
}
group(DefaultLayoutStep)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,50 +72,6 @@ page 31179 "Advance Letter Templates CZZ"
{
ApplicationArea = Basic, Suite;
}
#if not CLEAN23
#pragma warning disable AL0432,AS0074
field("Document Report ID"; '')
{
ApplicationArea = Basic, Suite;
ToolTip = 'Specifies document report ID.';
Visible = false;
Enabled = false;
ObsoleteReason = 'Replaced by standard report selection.';
ObsoleteState = Pending;
ObsoleteTag = '23.0';
}
field("Document Report Caption"; '')
{
ApplicationArea = Basic, Suite;
ToolTip = 'Specifies document report caption.';
Visible = false;
Enabled = false;
ObsoleteReason = 'Replaced by standard report selection.';
ObsoleteState = Pending;
ObsoleteTag = '23.0';
}
field("Invoice/Cr. Memo Report ID"; '')
{
ApplicationArea = Basic, Suite;
ToolTip = 'Specifies invoice/credit memo report ID';
Visible = false;
Enabled = false;
ObsoleteReason = 'Replaced by standard report selection.';
ObsoleteState = Pending;
ObsoleteTag = '23.0';
}
field("Invoice/Cr. Memo Rep. Caption"; '')
{
ApplicationArea = Basic, Suite;
ToolTip = 'Specifies invoice/credit memo report caption.';
Visible = false;
Enabled = false;
ObsoleteReason = 'Replaced by standard report selection.';
ObsoleteState = Pending;
ObsoleteTag = '23.0';
}
#pragma warning restore AL0432,AS0074
#endif
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,6 @@ using Microsoft.Finance.GeneralLedger.Setup;
using Microsoft.Finance.ReceivablesPayables;
using Microsoft.Finance.VAT.Calculation;
using Microsoft.Finance.VAT.Setup;
#if not CLEAN23
using Microsoft.FixedAssets.Journal;
#endif
using Microsoft.Foundation.Address;
using Microsoft.Foundation.Attachment;
using Microsoft.Foundation.AuditCodes;
Expand Down Expand Up @@ -1058,38 +1055,6 @@ table 31008 "Purch. Adv. Letter Header CZZ"
exit((not HasPayToAddress()) and PayToVendor.HasAddress());
end;

#if not CLEAN23
#pragma warning disable AL0432
[Obsolete('Temporary fix to convert Dim Arrays to Dictionary', '23.0')]
local procedure CreateDefaultDimSourcesFromDimArray(var DefaultDimSource: List of [Dictionary of [Integer, Code[20]]]; TableID: array[10] of Integer; No: array[10] of Code[20])
var
DimArrayConversionHelper: Codeunit "Dim. Array Conversion Helper";
begin
DimArrayConversionHelper.CreateDefaultDimSourcesFromDimArray(Database::"FA Journal Line", DefaultDimSource, TableID, No);
end;

[Obsolete('Temporary fix to convert Dim Arrays to Dictionary', '23.0')]
local procedure CreateDimTableIDs(DefaultDimSource: List of [Dictionary of [Integer, Code[20]]]; var TableID: array[10] of Integer; var No: array[10] of Code[20])
var
DimArrayConversionHelper: Codeunit "Dim. Array Conversion Helper";
begin
DimArrayConversionHelper.CreateDimTableIDs(Database::"FA Journal Line", DefaultDimSource, TableID, No);
end;

[Obsolete('Temporary fix to convert Dim Arrays to Dictionary', '23.0')]
local procedure RunEventOnAfterCreateDimTableIDs(var DefaultDimSource: List of [Dictionary of [Integer, Code[20]]])
var
DimArrayConversionHelper: Codeunit "Dim. Array Conversion Helper";
TableID: array[10] of Integer;
No: array[10] of Code[20];
begin
CreateDimTableIDs(DefaultDimSource, TableID, No);
OnAfterCreateDimTableIDs(Rec, CurrFieldNo, TableID, No);
CreateDefaultDimSourcesFromDimArray(DefaultDimSource, TableID, No);
end;
#pragma warning restore AL0432

#endif
procedure CreateDimFromDefaultDim(FieldNo: Integer)
var
DefaultDimSource: List of [Dictionary of [Integer, Code[20]]];
Expand All @@ -1104,11 +1069,6 @@ table 31008 "Purch. Adv. Letter Header CZZ"
DimensionManagement.AddDimSource(DefaultDimSource, Database::"Salesperson/Purchaser", Rec."Purchaser Code", FieldNo = Rec.FieldNo("Purchaser Code"));
DimensionManagement.AddDimSource(DefaultDimSource, Database::"Responsibility Center", Rec."Responsibility Center", FieldNo = Rec.FieldNo("Responsibility Center"));

#if not CLEAN23
#pragma warning disable AL0432
RunEventOnAfterCreateDimTableIDs(DefaultDimSource);
#pragma warning restore AL0432
#endif
OnAfterInitDefaultDimensionSources(Rec, DefaultDimSource);
end;

Expand Down Expand Up @@ -1713,16 +1673,6 @@ table 31008 "Purch. Adv. Letter Header CZZ"
begin
end;

#if not CLEAN23
#pragma warning disable AL0432
[Obsolete('Use OnAfterInitDefaultDimensionSources instead.', '23.0')]
[IntegrationEvent(false, false)]
local procedure OnAfterCreateDimTableIDs(var PurchAdvLetterHeaderCZZ: Record "Purch. Adv. Letter Header CZZ"; CallingFieldNo: Integer; var TableID: array[10] of Integer; var No: array[10] of Code[20])
begin
end;
#pragma warning restore AL0432

#endif
[IntegrationEvent(false, false)]
local procedure OnAfterUpdatePayToCont(var PurchAdvLetterHeaderCZZ: Record "Purch. Adv. Letter Header CZZ"; Vendor: Record Vendor; Contact: Record Contact)
begin
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ namespace Microsoft.Sales.History;

using Microsoft.Inventory.Item;
using Microsoft.Inventory.Journal;
using Microsoft.Inventory.Transfer;

codeunit 31444 "Undo Shipment Line Handler CZA"
{
Expand All @@ -19,4 +20,10 @@ codeunit 31444 "Undo Shipment Line Handler CZA"
Item.Get(ItemJournalLine."Item No.");
ItemJournalLine."Unit of Measure Code" := Item."Base Unit of Measure";
end;

[EventSubscriber(ObjectType::Codeunit, Codeunit::"Undo Transfer Shipment", 'OnAfterCopyItemJnlLineFromTransShpt', '', false, false)]
local procedure OnAfterCopyItemJnlLineFromTransShpt(var ItemJournalLine: Record "Item Journal Line"; TransferShipmentLine: Record "Transfer Shipment Line")
begin
ItemJournalLine."Gen. Bus. Posting Group" := TransferShipmentLine."Gen.Bus.Post.Group Ship CZA";
end;
}
Original file line number Diff line number Diff line change
Expand Up @@ -520,8 +520,8 @@ codeunit 31330 "Install Application CZB"
local procedure InitExpLauncherSEPA()
var
BankExportImportSetup: Record "Bank Export/Import Setup";
SEPACZCodeTok: Label 'SEPACZ', Locked = true;
SEPACZNameTxt: Label 'SEPA Czech';
SEPACZCodeTok: Label 'SEPACZPAIN00100109', Locked = true;
SEPACZNameTxt: Label 'SEPA Czech - payment orders pain.001.001.09';
begin
if not BankExportImportSetup.Get(SEPACZCodeTok) then begin
BankExportImportSetup.Init();
Expand All @@ -531,7 +531,7 @@ codeunit 31330 "Install Application CZB"
BankExportImportSetup.Name := SEPACZNameTxt;
BankExportImportSetup.Direction := BankExportImportSetup.Direction::Export;
BankExportImportSetup."Processing Codeunit ID" := Codeunit::"Export Launcher SEPA CZB";
BankExportImportSetup."Processing XMLport ID" := XmlPort::"SEPA CT pain.001.001.03";
BankExportImportSetup."Processing XMLport ID" := XmlPort::"SEPA CT pain.001.001.09";
BankExportImportSetup."Check Export Codeunit" := Codeunit::"SEPA CT-Check Line";
BankExportImportSetup."Preserve Non-Latin Characters" := false;
BankExportImportSetup.Modify();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -469,18 +469,4 @@ codeunit 31362 "Match Bank Payment CZB"
local procedure OnFillMatchBankPaymentBufferEmployeeOnAfterEmployeeLedgerEntrySetFilters(var EmployeeLedgerEntry: Record "Employee Ledger Entry"; SearchRuleLineCZB: Record "Search Rule Line CZB"; var GenJournalLine: Record "Gen. Journal Line")
begin
end;
#if not CLEAN23

[IntegrationEvent(false, false)]
[Obsolete('The event is no longer triggered.', '23.0')]
local procedure OnBeforeFillMatchBankPaymentBufferSalesAdvance(GenJournalLine: Record "Gen. Journal Line"; SearchRuleLineCZB: Record "Search Rule Line CZB"; var TempMatchBankPaymentBufferCZB: Record "Match Bank Payment Buffer CZB"; var IsHandled: Boolean);
begin
end;

[IntegrationEvent(false, false)]
[Obsolete('The event is no longer triggered.', '23.0')]
local procedure OnBeforeFillMatchBankPaymentBufferPurchaseAdvance(GenJournalLine: Record "Gen. Journal Line"; SearchRuleLineCZB: Record "Search Rule Line CZB"; var TempMatchBankPaymentBufferCZB: Record "Match Bank Payment Buffer CZB"; var IsHandled: Boolean);
begin
end;
#endif
}
Original file line number Diff line number Diff line change
Expand Up @@ -220,9 +220,12 @@ table 11733 "Cash Document Line CZP"
end;
"Account Type"::Employee:
begin
CashDocumentHeaderCZP.TestField("Currency Code", '');
Employee.Get("Account No.");
Description := CopyStr(Employee.FullName(), 1, MaxStrLen(Description));
"Posting Group" := Employee."Employee Posting Group";
"Gen. Posting Type" := "Gen. Posting Type"::" ";
"VAT Bus. Posting Group" := '';
"VAT Prod. Posting Group" := '';
end;
end;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -380,36 +380,6 @@ codeunit 11796 "Corrections Posting Mgt. CZL"
ServiceLine."Negative CZL" := (ServiceLine.Quantity < 0);
end;

#if not CLEAN23
#pragma warning disable AL0432
[EventSubscriber(ObjectType::Table, Database::"Invoice Post. Buffer", 'OnAfterInvPostBufferPrepareSales', '', false, false)]
local procedure InvPostBufferSetCorrectionOnAfterInvPostBufferPrepareSales(var SalesLine: Record "Sales Line"; var InvoicePostBuffer: Record "Invoice Post. Buffer")
var
SalesHeader: Record "Sales Header";
begin
SalesHeader.Get(SalesLine."Document Type", SalesLine."Document No.");
InvoicePostBuffer."Correction CZL" := SalesHeader.Correction xor SalesLine."Negative CZL";
end;

[EventSubscriber(ObjectType::Table, Database::"Invoice Post. Buffer", 'OnAfterInvPostBufferPreparePurchase', '', false, false)]
local procedure InvPostBufferSetCorrectionOnAfterInvPostBufferPreparePurchase(var PurchaseLine: Record "Purchase Line"; var InvoicePostBuffer: Record "Invoice Post. Buffer")
var
PurchaseHeader: Record "Purchase Header";
begin
PurchaseHeader.Get(PurchaseLine."Document Type", PurchaseLine."Document No.");
InvoicePostBuffer."Correction CZL" := PurchaseHeader.Correction xor PurchaseLine."Negative CZL";
end;

[EventSubscriber(ObjectType::Table, Database::"Invoice Post. Buffer", 'OnAfterInvPostBufferPrepareService', '', false, false)]
local procedure InvPostBufferSetCorrectionOnAfterInvPostBufferPrepareService(var ServiceLine: Record "Service Line"; var InvoicePostBuffer: Record "Invoice Post. Buffer")
var
ServiceHeader: Record "Service Header";
begin
ServiceHeader.Get(ServiceLine."Document Type", ServiceLine."Document No.");
InvoicePostBuffer."Correction CZL" := ServiceHeader.Correction xor ServiceLine."Negative CZL";
end;
#pragma warning restore AL0432
#endif
[EventSubscriber(ObjectType::Codeunit, Codeunit::Microsoft.Sales.Posting."Sales Post Invoice Events", 'OnAfterPrepareInvoicePostingBuffer', '', false, false)]
local procedure SetCorrectionOnAfterPrepareSales(var SalesLine: Record "Sales Line"; var InvoicePostingBuffer: Record "Invoice Posting Buffer")
var
Expand Down
Loading

0 comments on commit 3116518

Please sign in to comment.