Release Branches #374
Merged
Release Branches #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jan 23, 2023
aholstrup1
reviewed
Jan 23, 2023
added 2 commits
January 24, 2023 15:29
mazhelez
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Partner filed two bugs on release branches - #360 and #371
I created an end-2-end scenario test, which tested how release branches was intended to work.
This did unfortunately reveal a few bugs in release branches handling, which all are fixed in this PR.
Also added some CI tests for the SemVer conversion functions and added comments to the code for these.
This PR also contains a fix for #376
And it contains updates to documentation on settings: