Skip to content
This repository has been archived by the owner on Dec 5, 2023. It is now read-only.

Commit

Permalink
Change port to be 80 by default
Browse files Browse the repository at this point in the history
- `Dockerfile` explicitly overrides `8081` with `80`, so might as well have it as the default: github.com/microservices-demo/catalogue/blob/master/docker/catalogue/Dockerfile#L45-L46
- Should one not realise this override is currently required (but no longer, after this change), issues like microservices-demo/microservices-demo/pull/767 could be experienced.
  • Loading branch information
marccarre committed Jun 8, 2018
1 parent 5712573 commit a7a0cb0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cmd/cataloguesvc/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ func init() {

func main() {
var (
port = flag.String("port", "8081", "Port to bind HTTP listener") // TODO(pb): should be -addr, default ":8081"
port = flag.String("port", "80", "Port to bind HTTP listener") // TODO(pb): should be -addr, default ":80"
images = flag.String("images", "./images/", "Image path")
dsn = flag.String("DSN", "catalogue_user:default_password@tcp(catalogue-db:3306)/socksdb", "Data Source Name: [username[:password]@][protocol[(address)]]/dbname")
zip = flag.String("zipkin", os.Getenv("ZIPKIN"), "Zipkin address")
Expand Down

0 comments on commit a7a0cb0

Please sign in to comment.