RedisCache Remove Blocking IO on Event Loop Thread #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RedisCache
constructor was making 2 calls that run the Redis commandcommand
to get a list of commands.new RedisAsyncCache();
syncCommands(this.connection);
This blocking command is being run from a Netty Event Loop Group thread where the constructor is called, which causes problems since
nioEventLoopGroup
threads should not have any blocking calls run on them.