Fix rabbitmq container deprecations and test code cleanup. #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timyates
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
- Fixed the tests
It seems that since Rabbit 3.9.x the waitForConfirms comes back immediately with false if the message can't be confirmed. Previously I think it threw a TimeoutException
- and removed the deprecation from
TemporarilyDownConsumersSpec
Used portBindings on a RabbitMq container and updated the image verson
- Use the same Rabbit version
We were using multiple rabbit versions, I moved the all to use the version in AbstractRabbitMQTest
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to support using RabbitMQ Docker containers newer than 3.8
closes #594