Send application events before/after RabbitMQ consumer subscribe to a queue #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdelamo
requested changes
Aug 4, 2023
rabbitmq/src/main/java/io/micronaut/rabbitmq/intercept/RabbitMQConsumerAdvice.java
Show resolved
Hide resolved
rabbitmq/src/main/java/io/micronaut/rabbitmq/intercept/RabbitMQConsumerAdvice.java
Outdated
Show resolved
Hide resolved
...ample-groovy/src/test/groovy/io/micronaut/rabbitmq/docs/event/MyStartingEventListener.groovy
Outdated
Show resolved
Hide resolved
...ples/example-java/src/test/java/io/micronaut/rabbitmq/docs/event/MyStartedEventListener.java
Outdated
Show resolved
Hide resolved
...les/example-java/src/test/java/io/micronaut/rabbitmq/docs/event/MyStartingEventListener.java
Outdated
Show resolved
Hide resolved
...es/example-kotlin/src/test/kotlin/io/micronaut/rabbitmq/docs/event/MyStartedEventListener.kt
Outdated
Show resolved
Hide resolved
...s/example-kotlin/src/test/kotlin/io/micronaut/rabbitmq/docs/event/MyStartingEventListener.kt
Outdated
Show resolved
Hide resolved
|
@aniljaiswal Will this proposed solution help your use case? |
sdelamo
requested changes
Aug 4, 2023
rabbitmq/src/main/java/io/micronaut/rabbitmq/intercept/RabbitMQConsumerAdvice.java
Show resolved
Hide resolved
sdelamo
requested changes
Aug 5, 2023
rabbitmq/src/main/java/io/micronaut/rabbitmq/intercept/RabbitMQConsumerAdvice.java
Outdated
Show resolved
Hide resolved
guillermocalvo
commented
Aug 7, 2023
rabbitmq/src/main/java/io/micronaut/rabbitmq/intercept/RabbitMQConsumerAdvice.java
Outdated
Show resolved
Hide resolved
sdelamo
requested changes
Aug 14, 2023
rabbitmq/src/main/java/io/micronaut/rabbitmq/intercept/RabbitMQConsumerAdvice.java
Outdated
Show resolved
Hide resolved
rabbitmq/src/main/java/io/micronaut/rabbitmq/intercept/RabbitMQConsumerAdvice.java
Outdated
Show resolved
Hide resolved
rabbitmq/src/main/java/io/micronaut/rabbitmq/intercept/RabbitMQConsumerAdvice.java
Outdated
Show resolved
Hide resolved
rabbitmq/src/main/java/io/micronaut/rabbitmq/intercept/RabbitMQConsumerAdvice.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Sergio del Amo <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
sdelamo
approved these changes
Aug 14, 2023
sdelamo
deleted the
423-listeners-start-consuming-messages-before-micronaut-startup-event
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #423
Instead of delaying message consumption, we will emit application events so that users can take any necessary actions before/after RabbitMQ consumers subscribe to a queue.