Issue-298 Consumer is not closed on application shutdown #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbodvanski
commented
Oct 25, 2022
| @@ -486,7 +486,8 @@ public void handleDelivery(String consumerTag, Envelope envelope, AMQP.BasicProp | |||
| // memory and will call handleDelivery for these messages, even if they are re-queued by the broker. | |||
| // The client will be unable to acknowledge these messages. So it is safe to silently discard | |||
| // them, without bothering the callback handler. | |||
| if (!getChannel().isOpen()) { | |||
There was a problem hiding this comment.
There's already a chunk of code in the RecoverableConsumerWrapper.cancel() method, which upon receiving the SIGTERM signal, makes sure to finish the processing for the message[s] that have been already delivered to the consumer threads. With this fix, the rest of the queued messages are not going to be pulled from the queue after receiving the SIGTERM signal, and as a result, consumers have been canceled.
|
The Static Analysis build tasks failure cuase: |
graemerocher
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.