Problem JSON to M5 and register problem+json as an additional type for JSON Codec #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdelamo
changed the title
sdelamo
commented
May 25, 2023
|
|
||
| @Override | ||
| public Map<String, Object> read(String name, InputStream input) throws IOException { | ||
| return propertySource.asMap(); |
There was a problem hiding this comment.
Not sure how this method be overriden in this context
graemerocher
requested changes
May 25, 2023
@graemerocher it does not to work with a |
|
@graemerocher I have documented as a breaking change that the user needs to specify the additional type for the JSON codec via configuration. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
the other option is to define a |
graemerocher
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates to Micronaut Core M5 but also provides a PropertySourceLoader so that the user does not have to explicitly register problem+json as an additional type for JSON Codec.