try to fix groovy issue #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es to correspond to changed bom/platform architecture, misc build fixes.
# Conflicts: # .github/workflows/graalvm.yml # .github/workflows/gradle.yml
…r-mn4 # Conflicts: # .github/workflows/graalvm.yml # .github/workflows/gradle.yml
wetted
suggested changes
Apr 6, 2023
examples/micronaut-client/src/test/groovy/micronaut/client/utils/KubernetesSpecification.groovy
Outdated
Show resolved
Hide resolved
Co-authored-by: Dean Wette <[email protected]>
Co-authored-by: Dean Wette <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
wetted
approved these changes
Apr 6, 2023
|
@sdelamo this looks like it ready now. |
sdelamo
approved these changes
Apr 10, 2023
| @@ -48,3 +42,9 @@ tasks { | |||
| } | |||
| } | |||
|
|
|||
| configurations.all { | |||
There was a problem hiding this comment.
This is not necessary with Micronaut Framework 4.0, since Micronaut Framework 4.0 does not longer expose micronaut-jackson-databind automatically.
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package micronaut.client.utils |
There was a problem hiding this comment.
is there a reason why we use a package not starting with io.micronaut but micronaut instead?
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package micronaut.informer.utils |
There was a problem hiding this comment.
should this package be io.micronaut.informer.utils instead?
| @@ -47,3 +41,10 @@ tasks { | |||
| images = ['micronaut-kubernetes-operator-example'] | |||
| } | |||
| } | |||
|
|
|||
| configurations.all { | |||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package micronaut.operator.utils |
There was a problem hiding this comment.
should the package be io.micronaut.operator.utils?
| io-fabric8-kubernetes-client = '6.5.1' | ||
|
|
||
| micronaut-discovery = "4.0.0-M1" | ||
| micronaut-logging = "1.0.0-SNAPSHOT" |
There was a problem hiding this comment.
Suggested change
| micronaut-logging = "1.0.0-SNAPSHOT" | |
| micronaut-logging = "1.0.0-M1" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.