Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-language docs examples for Kafka Streams #839

Merged
merged 15 commits into from
Aug 29, 2023
Merged

Multi-language docs examples for Kafka Streams #839

merged 15 commits into from
Aug 29, 2023

Conversation

wetted
Copy link
Contributor

@wetted wetted commented Aug 23, 2023

No description provided.

@wetted wetted self-assigned this Aug 23, 2023
@wetted wetted requested a review from guillermocalvo August 24, 2023 20:56
@guillermocalvo
Copy link
Contributor

LGTM 👍

@wetted wetted requested a review from guillermocalvo August 25, 2023 17:57
@wetted wetted marked this pull request as ready for review August 28, 2023 14:06
@wetted wetted requested a review from sdelamo August 28, 2023 14:06
@sdelamo
Copy link
Contributor

sdelamo commented Aug 28, 2023

LGTM 👍

@guillermocalvo Please, use the GitHub review PR functionality to signal whether you approve, reject or leave comments in a PR.

@guillermocalvo
Copy link
Contributor

@guillermocalvo Please, use the GitHub review PR functionality to signal whether you approve, reject or leave comments in a PR.

@sdelamo I left a comment because at the time the PR was not ready for review yet. Do you guys usually approve/reject draft PRs? I can do that next time.

@sdelamo
Copy link
Contributor

sdelamo commented Aug 28, 2023

@guillermocalvo Please, use the GitHub review PR functionality to signal whether you approve, reject or leave comments in a PR.

@sdelamo I left a comment because at the time the PR was not ready for review yet. Do you guys usually approve/reject draft PRs? I can do that next time.

no, we don't review Draft PRs generally.

@guillermocalvo
Copy link
Contributor

guillermocalvo commented Aug 28, 2023 •
edited
Loading

no, we don't review Draft PRs generally.

@sdelamo That's what I thought, which is why I left a comment in the draft PR to indicate that it looked good to me so far.

guillermocalvo
guillermocalvo suggested changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@guillermocalvo guillermocalvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WordCountStreamTest is satisfied if client.publishSentence() doesn't throw any exceptions; I don't believe that's proof enough that the Kafka stream is doing its job, is it?

I'm also missing WordCountStreamTest for test-suite-groovy and test-suite-groovy.

test-suite/src/test/java/io/micronaut/kafka/docs/streams/WordCountStreamTest.java Outdated Show resolved Hide resolved
@wetted wetted requested a review from guillermocalvo August 28, 2023 20:46
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wetted wetted merged commit 7534bad into master Aug 29, 2023
@wetted wetted deleted the docs-examples-streams branch August 29, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillermocalvo guillermocalvo guillermocalvo approved these changes

@sdelamo sdelamo sdelamo approved these changes

Assignees

@wetted wetted

Labels
type: docs
Projects
No open projects
4.1.0 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wetted @guillermocalvo @sdelamo