Multi-language documentation for Configuring Consumer examples #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wetted
changed the title
guillermocalvo
suggested changes
Aug 25, 2023
...-suite-groovy/src/test/groovy/io/micronaut/kafka/docs/consumer/topics/ProductListener.groovy
Outdated
Show resolved
Hide resolved
...-suite-groovy/src/test/groovy/io/micronaut/kafka/docs/consumer/topics/ProductListener.groovy
Outdated
Show resolved
Hide resolved
test-suite-kotlin/src/test/kotlin/io/micronaut/kafka/docs/consumer/topics/ProductListener.kt
Outdated
Show resolved
Hide resolved
test-suite-kotlin/src/test/kotlin/io/micronaut/kafka/docs/consumer/topics/ProductListener.kt
Outdated
Show resolved
Hide resolved
test-suite/src/test/java/io/micronaut/kafka/docs/consumer/topics/ProductListener.java
Outdated
Show resolved
Hide resolved
...ovy/src/test/groovy/io/micronaut/kafka/docs/consumer/config/ConfigProductListenerTest.groovy
Outdated
Show resolved
Hide resolved
...-kotlin/src/test/kotlin/io/micronaut/kafka/docs/consumer/config/ConfigProductListenerTest.kt
Outdated
Show resolved
Hide resolved
test-suite/src/test/java/io/micronaut/kafka/docs/consumer/config/ConfigProductListenerTest.java
Outdated
Show resolved
Hide resolved
test-suite-kotlin/src/test/kotlin/io/micronaut/kafka/docs/consumer/config/ProductClient.kt
Outdated
Show resolved
Hide resolved
test-suite/src/test/java/io/micronaut/kafka/docs/consumer/config/ProductClient.java
Outdated
Show resolved
Hide resolved
guillermocalvo
approved these changes
Aug 28, 2023
sdelamo
requested changes
Aug 28, 2023
...-kotlin/src/test/kotlin/io/micronaut/kafka/docs/consumer/config/ConfigProductListenerTest.kt
Outdated
Show resolved
Hide resolved
test-suite-kotlin/src/test/kotlin/io/micronaut/kafka/docs/consumer/reactive/ProductListener.kt
Outdated
Show resolved
Hide resolved
test-suite-kotlin/src/test/kotlin/io/micronaut/kafka/docs/consumer/reactive/ProductListener.kt
Outdated
Show resolved
Hide resolved
test-suite-kotlin/src/test/kotlin/io/micronaut/kafka/docs/consumer/topics/ProductListener.kt
Outdated
Show resolved
Hide resolved
test-suite-kotlin/src/test/kotlin/io/micronaut/kafka/docs/consumer/topics/ProductListener.kt
Outdated
Show resolved
Hide resolved
test-suite-kotlin/src/test/kotlin/io/micronaut/kafka/docs/seek/rebalance/ProductClient.kt
Show resolved
Hide resolved
test-suite/src/test/java/io/micronaut/kafka/docs/consumer/config/ConfigProductListenerTest.java
Show resolved
Hide resolved
sdelamo
approved these changes
Aug 28, 2023
|
@sdelamo for the LOG statements, would it be more correct to use: There are other instances of Kotlin docs-examples using println. I am planning to create a "cleanup" PR to go through all the docs and do a final cleanup, so I can correct this. in all the examples that have it. |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.