Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-language documentation for Quickstart example #822

Merged
merged 8 commits into from
Aug 18, 2023

Conversation

wetted
Copy link
Contributor

@wetted wetted commented Aug 17, 2023

No description provided.

@wetted wetted self-assigned this Aug 17, 2023
@wetted wetted marked this pull request as ready for review August 17, 2023 19:47
@wetted wetted requested review from timyates and sdelamo August 17, 2023 19:47
@wetted
Copy link
Contributor Author

wetted commented Aug 17, 2023

@sdelamo @timyates I'm puzzled why the test-suite test case fails. It passes locally for me every time. Ugh.

@sdelamo
Copy link
Contributor

sdelamo commented Aug 18, 2023

it was failing for me locally as well. I have fixed the tests.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sdelamo sdelamo merged commit bcc349f into master Aug 18, 2023
@sdelamo sdelamo deleted the docs-examples-quickstart branch August 18, 2023 07:07
@timyates
Copy link
Contributor

I still think

    static {
        MY_KAFKA = new KafkaContainer(DockerImageName.parse("confluentinc/cp-kafka:latest"))
        MY_KAFKA.start()
    }

Is an anti-pattern especially in Spock tests

@sdelamo
Copy link
Contributor

sdelamo commented Aug 18, 2023

I still think

    static {
        MY_KAFKA = new KafkaContainer(DockerImageName.parse("confluentinc/cp-kafka:latest"))
        MY_KAFKA.start()
    }

Is an anti-pattern especially in Spock tests

Please, @timyates send an additional PR.

@timyates
Copy link
Contributor

#824

👍

@wetted
Copy link
Contributor Author

wetted commented Aug 18, 2023

#824

@sdelamo @timyates
The reason I wasn't using the AbstractKafkaTest in my new examples, but left it is because the docs recommend using micronaut-test-resources which is what I intended for new examples. However, the docs have a section and example of using Testcontainers directly, thus AbstractKafkaTest. See https://micronaut-projects.github.io/micronaut-kafka/latest/guide/#kafkaDockerized

We need the same fix for the Java and Kotlin AbstractKafkaTest docs examples. I'll do that on my next PR.

@wetted
Copy link
Contributor Author

wetted commented Aug 18, 2023

#825

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants