Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI never ends for unit tests with manual test container lifecycle control #782

Merged
merged 4 commits into from
Jul 28, 2023
Merged

CI never ends for unit tests with manual test container lifecycle control #782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
86a4c37
build: projectVersion to 5.1.0-SNAPSHOT
sdelamo Jul 20, 2023
a46601e
Make `ConsumerState.closedState` volatile
guillermocalvo Jul 20, 2023
d4c7c12
Reactivate the tests
guillermocalvo Jul 20, 2023
596d61b
Update gradle.properties
sdelamo Jul 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kafka/src/main/java/io/micronaut/configuration/kafka/processor/KafkaConsumerProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1084,7 +1084,7 @@ private static final class ConsumerState {
final boolean useSendOffsetsToTransaction;
final boolean isMessageReturnType;
final boolean isMessagesIterableReturnType;
ConsumerCloseState closedState;
volatile ConsumerCloseState closedState;

private ConsumerState(String clientId, String groupId, OffsetStrategy offsetStrategy, Consumer<?, ?> consumer, Object consumerBean, Set<String> subscriptions,
AnnotationValue<KafkaListener> kafkaListener, ExecutableMethod<?, ?> method) {
Expand Down
2 changes: 0 additions & 2 deletions test-suite-groovy/src/test/groovy/io/micronaut/kafka/docs/MyTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,12 @@ import io.micronaut.configuration.kafka.annotation.*
import io.micronaut.context.annotation.*
import io.micronaut.test.extensions.spock.annotation.MicronautTest
import jakarta.inject.Inject
import spock.lang.Ignore

import static java.util.concurrent.TimeUnit.SECONDS
import static org.awaitility.Awaitility.await

@Property(name = "spec.name", value = "MyTest")
@MicronautTest
@Ignore("It hangs forever in the CI")
class MyTest extends AbstractKafkaTest {

@Inject
Expand Down
1 change: 0 additions & 1 deletion test-suite-kotlin/src/test/kotlin/io/micronaut/kafka/docs/MyTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import java.util.concurrent.*
@Property(name = "spec.name", value = "MyTest")
@MicronautTest
@TestInstance(TestInstance.Lifecycle.PER_CLASS)
@Disabled("It hangs forever in the CI")
internal class MyTest : AbstractKafkaTest() {
@Test
fun testKafkaRunning(producer: MyProducer, consumer: MyConsumer) {
Expand Down
1 change: 0 additions & 1 deletion test-suite/src/test/java/io/micronaut/kafka/docs/MyTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
@Property(name = "spec.name", value = "MyTest")
@MicronautTest
@TestInstance(TestInstance.Lifecycle.PER_CLASS)
@Disabled("It hangs forever in the CI")
class MyTest extends AbstractKafkaTest {
@Test
void testKafkaRunning(MyProducer producer, MyConsumer consumer) {
Expand Down