Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing @Singleton #633

Merged
merged 3 commits into from
Aug 16, 2023
Merged

Missing @Singleton #633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3dbb47b
Missing @Singleton
agustin-tecso Dec 5, 2022
22e57dd
Move example classes to a different java package
guillermocalvo Aug 4, 2023
4cef524
Add test to make sure that the fallback bean exists in the context
guillermocalvo Aug 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...docs/producer/fallback/MessageClient.java → ...docs/producer/fallback/MessageClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
package io.micronaut.configuration.kafka.docs.producer.fallback;
package docs.producer.fallback;

import io.micronaut.configuration.kafka.annotation.KafkaClient;
import io.micronaut.configuration.kafka.annotation.Topic;
import io.micronaut.context.annotation.Requires;

@Requires(property = "spec.name", value = "MessageClientFallbackSpec")
@KafkaClient
public interface MessageClient {

Expand Down
5 changes: 4 additions & 1 deletion ...ducer/fallback/MessageClientFallback.java → ...ducer/fallback/MessageClientFallback.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,17 @@
package io.micronaut.configuration.kafka.docs.producer.fallback;
package docs.producer.fallback;

// tag::imports[]
import io.micronaut.context.annotation.Replaces;
import io.micronaut.context.annotation.Requires;
import io.micronaut.core.util.StringUtils;
import jakarta.inject.Singleton;
// end::imports[]

@Requires(property = "spec.name", value = "MessageClientFallbackSpec")
// tag::clazz[]
@Requires(property = "kafka.enabled", notEquals = StringUtils.TRUE, defaultValue = StringUtils.TRUE) // <1>
@Replaces(MessageClient.class) // <2>
@Singleton
public class MessageClientFallback implements MessageClient { // <3>

@Override
Expand Down
30 changes: 30 additions & 0 deletions kafka/src/test/groovy/docs/producer/fallback/MessageClientFallbackSpec.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
package docs.producer.fallback

import io.micronaut.context.ApplicationContext
import io.micronaut.context.annotation.Property
import io.micronaut.test.extensions.spock.annotation.MicronautTest
import jakarta.inject.Inject
import spock.lang.Specification

@MicronautTest
@Property(name = "spec.name", value = "MessageClientFallbackSpec")
@Property(name = "kafka.enabled", value = "false")
class MessageClientFallbackSpec extends Specification {

@Inject
ApplicationContext context

void "test that context contains the fallback bean"() {
when:
MessageClientFallback bean = context.getBean(MessageClientFallback)

then:
bean != null

when:
bean.send('message')

then:
thrown(UnsupportedOperationException)
}
}
4 changes: 2 additions & 2 deletions src/main/docs/guide/kafkaApplications/kafkaDisabled.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ You must, however, provide your own replacement implementations of any `@KafkaCl
.Creating Replacement KafkaClient Implementations
[source,java]
----
include::{testskafka}/producer/fallback/MessageClientFallback.java[tags=imports, indent=0]
include::kafka/src/test/groovy/docs/producer/fallback/MessageClientFallback.java[tags=imports, indent=0]

include::{testskafka}/producer/fallback/MessageClientFallback.java[tags=clazz, indent=0]
include::kafka/src/test/groovy/docs/producer/fallback/MessageClientFallback.java[tags=clazz, indent=0]
----

<1> Only instantiate when `kafka.enabled` is set to `false`
Expand Down