Use the current JDK for testing, but 17 for building #9989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we added a PR to run (and compile) under Java 21 #9978 This did not work as expected, as in reality this is configuring under the current JDK, but compilation is being done by Java 17 from the ToolChain set up by the micronaut-build plugin. This PR modifies the test tasks to run on the JDK that is used to start the build. But all compilation will be done via Java 17 from the toolchain.
melix
approved these changes
Oct 17, 2023
|
There is no need for the open hack? |
|
@dstepanov I'm changing my answer 😉 We do need the open hack, as no matter what I try, I cannot get a kotlin daemon to start with the toolchain JDK Added it in c60ac06 |
I cannot work out how to launch the kotlin daemon on the toolchain jdk
|
@yawkat do the test changes I had to make make sense? I think with 21 we get an extra executer |
Closed
|
Kudos, SonarCloud Quality Gate passed!
|
sdelamo
approved these changes
Oct 18, 2023
dstepanov
approved these changes
Oct 20, 2023
sdelamo
added
the
relates-to: build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we added a PR to run (and compile) under Java 21
#9978
This did not work as expected, as in reality this is configuring under the current JDK, but compilation is being done by Java 17 from the ToolChain set up by the micronaut-build plugin.
This PR modifies the test tasks to run on the JDK that is used to start the build.
But all compilation will be done via Java 17 from the toolchain.
I believe this supersedes both #9978 and #9985