Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Milestone versions #9085

Merged
merged 3 commits into from
Apr 11, 2023
Merged

use Milestone versions #9085

merged 3 commits into from
Apr 11, 2023

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Apr 11, 2023

No description provided.

@sdelamo
Copy link
Contributor Author

sdelamo commented Apr 11, 2023

@timyates can you check why this fails?

@timyates
Copy link
Contributor

Failing scan here (obfuscated in the action) https://ge.micronaut.io/s/cizejqpdmkbeq

H2 version was updated in the micronaut-sql bom

This commit aligns those versions, and fixes the test
@timyates
Copy link
Contributor

The management test was failing as micronaut-sql was adding a constraint on a newer version of H2 than we had in core (so the version string was different)

I've fixed the version string in the test, and aligned the version here to match that in micronaut-sql

@timyates
Copy link
Contributor

For the KSP error, we need M3 of the validation library with micronaut-projects/micronaut-validation@eea7bd0

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sdelamo sdelamo merged commit 5113c33 into 4.0.x Apr 11, 2023
@sdelamo sdelamo deleted the m1 branch April 11, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants