More performance optimizations #9076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graemerocher
approved these changes
Apr 6, 2023
yawkat
reviewed
Apr 11, 2023
| * @since 4.0.0 | ||
| */ | ||
| default MutableHttpResponse<?> toMutableResponse() { | ||
| if (this instanceof MutableHttpResponse<?> mutableHttpResponse) { |
There was a problem hiding this comment.
just override it in MutableHttpResponse instead
There was a problem hiding this comment.
oh i see you did that, remove this check then.
yawkat
reviewed
Apr 11, 2023
router/src/main/java/io/micronaut/web/router/DefaultMethodBasedRouteInfo.java
Outdated
Show resolved
Hide resolved
yawkat
reviewed
Apr 11, 2023
|
|
||
| @Override | ||
| public boolean needsRequestBody() { | ||
| return needsBody || super.needsRequestBody(); |
There was a problem hiding this comment.
i think you could fold super.needsRequestBody into needsBody too, call it in the constructor. probably doesn't matter though.
yawkat
approved these changes
Apr 11, 2023
…dRouteInfo.java Co-authored-by: Jonas Konrad <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.