Expose ConnectionManager for use in Oracle Cloud Netty client #9073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed. |
graemerocher
approved these changes
Apr 6, 2023
sdelamo
approved these changes
Apr 10, 2023
| * | ||
| * @return The connection manager of this client | ||
| */ | ||
| public ConnectionManager connectionManager() { |
There was a problem hiding this comment.
Annotate with @NonNull the return type?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes some ConnectionManager APIs in the netty http client so that I can use them to implement connection pooling in oraclecloud-httpclient-netty. Unfortunately OCI is still peculiar about how requests are processed so the client cannot be implemented with the normal Micronaut HTTP client API, but ConnectionManager offers a good enough API to make use of the basic HTTP stack (SSL, HTTP2/HTTP3...) and connection pooling.
ConnectionManager did change a bit in 4.0.x, and connection pooling for oraclecloud-httpclient-netty isn't super urgent, which is why this PR is targeted to 4.0.x.
In local testing these changes in micronaut-core are sufficient to implement the pooling client. I need to do more thorough testing though.