Logback configuration defined via JAVA_TOOL_OPTIONS is ignored #9009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we only checked the classpath for logback configuration files, and when refreshing we ignored the `logback.configurationFile` setting. This PR checks the filesystem if the config cannot be found on the classpath It also adds `logback.configurationFile` as an optional property that points to the location of the config for when we refresh the configuration. `logback.configurationFile` has precedence over the existing `logger.config` property
sdelamo
requested changes
Mar 27, 2023
runtime/src/main/java/io/micronaut/logging/impl/LogbackLoggingSystem.java
Outdated
Show resolved
Hide resolved
graemerocher
approved these changes
Mar 27, 2023
sdelamo
approved these changes
Mar 28, 2023
|
Kudos, SonarCloud Quality Gate passed! |
This was referenced Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8596
Previously, we only checked the classpath for logback configuration files, and when refreshing we ignored the
logback.configurationFilesetting.This PR checks the filesystem if the config cannot be found on the classpath
It also adds
logback.configurationFileas an optional property that points to the location of the config for when we refresh the configuration.logback.configurationFilehas precedence over the existinglogger.configproperty