Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add missing groovy tests #9000

Merged

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Mar 23, 2023

No description provided.

@sdelamo sdelamo requested a review from graemerocher March 23, 2023 17:47
@@ -9,7 +9,7 @@ class ExampleJob {

@Scheduled(
fixedRate = "1s",
condition = "#{!jobControl.paused}") // <1>
condition = '#{!jobControl.paused}') // <1>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not required but I think it is better to show in the docs strings with single quotes to avoid the user falling into the trap of creating a GString with string interpolation.

@graemerocher graemerocher merged commit f503fd3 into compile-time-expression-language Mar 23, 2023
@graemerocher graemerocher deleted the compile-time-expressions2 branch March 23, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants