Allow setting URL encoding/decoding to RFC 3986 #11513
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstepanov
requested changes
Jan 17, 2025
http/src/test/groovy/io/micronaut/http/uri/UriBuilderSpec.groovy
Outdated
Show resolved
Hide resolved
|
still working on this PR, since trying to address decoding |
graemerocher
commented
Jan 17, 2025
| def result = client.toBlocking().retrieve(req) | ||
|
|
||
| expect:"resolved values should using RFC-3986 decoding" | ||
| // TODO: investigate why Netty QueryStringDecoder.parameters() doesn't respect RFC-3986 |
There was a problem hiding this comment.
According to netty/netty@270e9d6 the decoding of + into space was supposed to be fixed, but it doesn't seem to be fixed for the parameters() method of QueryStringDecoder. We need to investigate if this is a bug in Netty or by design.
graemerocher
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce new UrlEncodingKind enum that can be configured from the client configuration for encoding and the router configuration for decoding adapting the URL encoding/decoding to RFC-3986.
Micronaut 5 should likely default to RFC-3986 for everything except form decoding.
Fixes #11434
Fixes #10564
This resolves almost everything, but there appear to be issues with Netty's
parameters()method ofQueryStringDecoder. Which seems to be designed for decodingapplication/x-www-form-urlencodednotRFC-3986.