Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests and documentation for datastax driver SSL integration #403

Merged
merged 21 commits into from
Jan 26, 2024

Conversation

wetted
Copy link
Contributor

@wetted wetted commented Jan 18, 2024

@wetted wetted requested a review from timyates January 18, 2024 18:24
@wetted wetted self-assigned this Jan 18, 2024
Copy link
Contributor

@timyates timyates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work? Don't we need to do something to add the certificate to cassandra running in the container?

Can we add a test in here that verifies:

  1. The connection is using SSL
  2. Queries can be made against cassandra

@wetted
Copy link
Contributor Author

wetted commented Jan 23, 2024

Still trying to get this working. See also: #404

timyates and others added 4 commits January 24, 2024 15:05
* Try to configure cassandra for ssl

Follow some instructions to generate truststore and keystore files.
Grab the configuration for Cassandra 4.x and update the config to point to these files.
Copy the files to the container

Still doesn't work

* Add missing files

* Fix SSL tests
@wetted
Copy link
Contributor Author

wetted commented Jan 24, 2024

The Sonarcloud complaint about test coverage is bogus (wrong).

Also, remove unrequired stuff from build
Copy link
Contributor

@timyates timyates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of tweaks suggested for the docs?

src/main/docs/guide/ssl.adoc Outdated Show resolved Hide resolved
src/main/docs/guide/ssl.adoc Outdated Show resolved Hide resolved
src/main/docs/guide/ssl.adoc Outdated Show resolved Hide resolved
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@wetted wetted marked this pull request as ready for review January 25, 2024 17:45
@wetted wetted requested review from timyates and sdelamo January 25, 2024 17:45
@sdelamo sdelamo merged commit 95c56b0 into master Jan 26, 2024
11 checks passed
@sdelamo sdelamo deleted the ssl-integration branch January 26, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Configure SSLOptions and JKS Via Config
3 participants