deps: bumps to Brave 6.0.0 and moves off internal type #511
Conversation
| @@ -16,7 +16,6 @@ | |||
| package io.micrometer.tracing.brave.bridge; | |||
|
|
|||
| import brave.internal.baggage.BaggageFields; | |||
There was a problem hiding this comment.
this is also an internal type, but not being removed so far.. maybe by accident ;)
There was a problem hiding this comment.
p.s I'm not sure if this was copied because brave's wasn't published to maven central. It is now, so maybe can reduce maintenance here https://central.sonatype.com/artifact/io.zipkin.contrib.brave-propagation-w3c/brave-propagation-tracecontext/versions from https://github.com/openzipkin-contrib/brave-propagation-w3c
There was a problem hiding this comment.
I think that was the reason, thanks for mentioning this!
There was a problem hiding this comment.
Actually I think I copied this code from OTel and adopted it to Brave. It was a long time ago so I don't really remember 🤷
There was a problem hiding this comment.
could have been. in any case this variant was done a while back benchmarked etc to be same perf as the built-in b3 stuff. hopefully it helps
There was a problem hiding this comment.
yeah definitely was otel, not just your comments say that, but the impl is wrong!
There was a problem hiding this comment.
here's a PR to re-use the code I wrote a few years ago, highlighting the uberbug in the current impl #532
|
hold on this one until brave 6 is out as I want to cross-check it |
codefromthecrypt
force-pushed
the
brave-5.17.1
branch
from
9e058bd
to
1b40c82
Compare
codefromthecrypt
changed the title
codefromthecrypt
force-pushed
the
brave-5.17.1
branch
2 times, most recently
from
de4bb2c
to
e825600
Compare
codefromthecrypt
force-pushed
the
brave-5.17.1
branch
2 times, most recently
from
e672867
to
e68bede
Compare
gradle/libs.versions.toml
Outdated
| @@ -20,7 +21,12 @@ awaitility = "4.2.0" | |||
| mockito = "5.8.0" | |||
| wiremock = "3.0.1" | |||
| testcontainers = "1.19.3" | |||
| braveBom = "5.17.0" | |||
| braveBom = "6.0.0" | |||
| # TODO: Update to 3.1.0 after https://github.com/open-telemetry/opentelemetry-java/pull/6129 | |||
There was a problem hiding this comment.
hope these notes make sense cc @marcingrzejszczak!
This updates to Brave 6.0.0 and dodges an internal type that is not in Brave 6.0. Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
force-pushed
the
brave-5.17.1
branch
from
e68bede
to
d11d803
Compare
marcingrzejszczak
merged commit 5bbc418
into
micrometer-metrics:main
marcingrzejszczak
added
enhancement
This updates to Brave 6.0.0 and dodges an internal type that is not in Brave 6.0.