Add basic integration test for OtlpMeterRegistry and the OTel collector #3668
Conversation
jonatan-ivanov
added
enhancement
| matchesPattern("(?s)^.*test_gauge\\{.+} 12\\n.*$"), | ||
|
|
||
| matchesPattern("(?s)^.*test_timer_count\\{.+} 1\\n.*$"), | ||
| matchesPattern("(?s)^.*test_timer_sum\\{.+} 123\\n.*$"), |
There was a problem hiding this comment.
Now that I'm looking at this, I don't think this is correct, this should be 123ms not 123s.
There was a problem hiding this comment.
Seems like a collector issue, the data that we send looks like this:
metrics {
name: "test.timer"
unit: "milliseconds"
histogram {
data_points {
start_time_unix_nano: 1677210838494000000
time_unix_nano: 1677210839021000000
count: 1
sum: 123.0
}
aggregation_temporality: AGGREGATION_TEMPORALITY_CUMULATIVE
}
}
There was a problem hiding this comment.
Created an issue to track this: open-telemetry/opentelemetry-collector-contrib#18903
There was a problem hiding this comment.
Good catch. I guess we'll need a fix in the collector before we can change the test.
There was a problem hiding this comment.
It seems like it might be intentional that no conversion is done currently. But then there's no way to know the unit as far as I can tell.
https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/pkg/translator/prometheus
There was a problem hiding this comment.
I'm wondering if there are receivers that mandate a unit that is not seconds.
Or two receivers that mandate different units. Or two exporters with different units.
In all of these cases I think not doing the conversion can lead to wrong result.
| // @formatter:off | ||
| return given() | ||
| .port(container.getMappedPort(9090)) | ||
| .accept(OPENMETRICS_100) |
There was a problem hiding this comment.
When I tried running the collector locally, I was not able to get it to return OpenMetrics format even when sending this Accept header and configuring the prometheus exporter with enable_open_metrics: true. Debugging this test, it looks like the response is also not OpenMetrics format.
There was a problem hiding this comment.
Great catch, I did not even notice this. This is another bug in the collector.
If I send 1.0.0 (what I should), it does not work:
Accept: application/openmetrics-text; version=1.0.0; charset=utf-8
If I send 0.0.1 (what I should not), it works:
Accept: application/openmetrics-text; version=0.0.1; charset=utf-8
See details here: open-telemetry/opentelemetry-collector-contrib#18913
There was a problem hiding this comment.
I fixed this by requesting (and verifying) 0.0.1 and also included a TODO item.
Resolves #3534