Honor configured step duration when building Wavefront senders #2173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shakuzen
added
bug
|
Thank you for reporting this and providing a fix. Sorry for the issue - it looks like we missed this when switching from using our own |
shakuzen
added a commit
that referenced
this pull request
Jul 3, 2020
Switches from setting the flush interval in seconds to milliseconds for added precision, though such a level of granularity is not usually important. Also adds tests to ensure the flush interval is set according to the configured step interval. See #2173
|
Yeah—I had the same struggle with testing, but think what you've come up with is reasonable. Cheers, and thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with the Wavefront registry where, no matter what is set for a
stepduration inWavefrontConfig, the Wavefront sender will always emit metrics once per second. I'm fairly confident the once-per-second behavior is not intended because it seems to go against the documentation forWavefrontConfig#step()and also against Wavefront's own example code, which shows providing astepofDuration.ofSeconds(10)with an explanation that:Cheers!