Honor configured step duration when building Wavefront senders #2173
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with the Wavefront registry where, no matter what is set for a
step
duration inWavefrontConfig
, the Wavefront sender will always emit metrics once per second. I'm fairly confident the once-per-second behavior is not intended because it seems to go against the documentation forWavefrontConfig#step()
and also against Wavefront's own example code, which shows providing astep
ofDuration.ofSeconds(10)
with an explanation that:Cheers!