Add logback logger context listener that re-adds MetricTurboFilters after logger context reset #2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shakuzen
approved these changes
Apr 27, 2020
There was a problem hiding this comment.
Thank you for the fix. We'll want to rebase this onto 1.1.x so we can merge it into there and forward from there to later maintenance branches and master.
Also, is the issue this fixes something we could easily reproduce in a unit test? If so, it'd be good to have a test for it.
|
You are right, this should be covered by a unit test, working on it right now. |
Add logback logger context listener that re-adds MetricTurboFilters after logger context reset (for instance when logback reloads its configuration).
bendiscz
force-pushed
the
logback_metrics_reset_listener
branch
from
a411509 to
1859b6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
LogbackMetricsstops to record logback events after logback LoggerContext reset. The reset can happen for instance when a configuration is reloaded via the "scan" feature. The reset listener solves this issue by re-adding all metrics turbo filters after every reset.Note that the metricsTurboFilters map was changed from a
ConcurrentHashMapto aHashMapwithsynchronizedblocks. This is to prevent a race-condition between a call tobindTomethod and logback reset event.Fixes #2028