-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Observed Tomcat Valve #3777
Comments
@marcingrzejszczak Do you have a solution to this? |
What are you seeking a solution for? |
Sry, maybe I misunderstood something. I am coming from this issue (Exceptions are not logged with span-id/trace-id with latest spring boot). There @bclozel mentioned this
Now it looks like this PR is still open for some reason. Do you see any chance that exceptions logged from tomcat itself can be enhanced with a trace-id/span-id? |
Tomcat valve instrumentation is done here - #3989 |
Example here https://github.com/micrometer-metrics/micrometer-samples/blob/4f9a6cd9d1c12fa19ec79a49766cce6afccd5ce2/micrometer-samples-boot3-web/src/main/java/io/micrometer/boot3/samples/web/ManualConfiguration.java#L41-L96
The text was updated successfully, but these errors were encountered: