Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last seen update for MySQL storage backend #42

Merged
merged 1 commit into from
May 7, 2022

Conversation

jessepeterson
Copy link
Member

Create a last_seen_at column in the MySQL schema and update it (nearly) every time the client talks to us.

@jessepeterson
Copy link
Member Author

Note there's a few edge cases where we can't update the last seen column. Notably because Declarative Management isn't "in scope" for the server the storage layer has no methods for it and thus if the client tries to talk to us there the storage will be none of the wiser. This is the case in the NanoMDM storage. That said the "important" beats of enrollment and command result storage & retrieval are covered (which includes Idle responses to pushes and are likely the only actual thing we care about).

Copy link

@kilpatds kilpatds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM?

@jessepeterson jessepeterson merged commit b6302bd into micromdm:main May 7, 2022
@jessepeterson jessepeterson deleted the last-seen branch April 22, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants