Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce maxLength default to 10,000 and revert maxSymbols change #40

Merged
merged 3 commits into from
May 21, 2024

Conversation

AaronMoat
Copy link
Contributor

Loved this comment @jonschlinkert : #37 (comment)

I have a bias for explicit configuration closer to the process - rather than an env var. Are we happy with simply lowering it?

@AaronMoat AaronMoat changed the title Snyk js braces 6838727 Reduce maxLength default to 10,000 May 21, 2024
@AaronMoat AaronMoat changed the title Reduce maxLength default to 10,000 Reduce maxLength default to 10,000 and revert maxSymbols change May 21, 2024
@AaronMoat AaronMoat changed the title Reduce maxLength default to 10,000 and revert maxSymbols change Reduce maxLength default to 10,000 and revert maxSymbols change May 21, 2024
@jonschlinkert jonschlinkert merged commit 415d660 into micromatch:master May 21, 2024
@AaronMoat AaronMoat deleted the SNYK-JS-BRACES-6838727 branch May 21, 2024 08:13
@thanhnhan2tn
Copy link

thanks for the merge, however I still see the issue still open, how should we resolve it?

@AaronMoat
Copy link
Contributor Author

@thanhnhan2tn do you mean the flagged security vulnerability in Snyk/Blackduck/et al? You'll need to talk to your security vendor and have them fix it on their end, as maintainers of OSS software cannot do that for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants