Skip to content
This repository has been archived by the owner on Oct 20, 2023. It is now read-only.

Docker Hub #24

Closed
dmotte opened this issue Mar 18, 2021 · 7 comments
Closed

Docker Hub #24

dmotte opened this issue Mar 18, 2021 · 7 comments
Assignees

Comments

@dmotte
Copy link

dmotte commented Mar 18, 2021

Hi! First of all, thanks for this software! 😃

It would be great to have the image in the Docker Hub, so one can do a docker pull without building it manually every time. Thanks in advance for your attention

@idashevskii
Copy link

I join the offer

@chclaus chclaus self-assigned this Apr 7, 2021
@chclaus
Copy link
Collaborator

chclaus commented Apr 7, 2021

Good Idea. I will take care of it.

@dmotte
Copy link
Author

dmotte commented Apr 7, 2021

@chclaus if you need inspiration on how to build it automatically for different architectures (amd64, arm, etc.), see this link from one of my recent projects https://github.com/dmotte/docker-portmap-client/tree/main/.github/workflows

There are two GitHub Actions workflows and in my opinion it is very simple to set up. You just have to copy the two .yml files, adapt them by changing the values (e.g. the image name) and set the DOCKERHUB_PASSWORD secret in the GitHub repo settings.

@chclaus
Copy link
Collaborator

chclaus commented Apr 7, 2021

Nice. Didn't worked with github actions until now.

Thanks. Stuff for tomorrow 😉

@chclaus
Copy link
Collaborator

chclaus commented Apr 27, 2021

Done. Results are here: https://hub.docker.com/repository/docker/micromata/dave/general

We currently have the issue, that the descriptions API of docker hub won't allow access tokens. peter-evans/dockerhub-description#10

But i think the main part is solved ;)

@chclaus chclaus closed this as completed Apr 27, 2021
@dmotte
Copy link
Author

dmotte commented Apr 27, 2021

@chclaus Thanks for your work! This is extremely useful! I suggest adding a link to the Docker Hub page in the README file, maybe in the Build and run with Docker section 😉 Something like this:

This image is also on **Docker Hub** as [`micromata/dave`](https://hub.docker.com/r/micromata/dave).

Result:

This image is also on Docker Hub as micromata/dave.

@chclaus
Copy link
Collaborator

chclaus commented Apr 28, 2021

Yeah.... missed this yesterday @dmotte. Thanks for the reminder. ;)

chclaus added a commit that referenced this issue Apr 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants