💚 Fixing unit tests

[VadimZvf]

Unit tests don't pass in the master branch.
They fail with the next error:

  2) <ArrayGroup />
       ArrayGroup renders at root:
     TypeError: Cannot read properties of undefined (reading 'load')
      at render (/home/runner/work/react-json-view/react-json-view/node_modules/enzyme/build/render.js:38:31)
      at Context.<anonymous> (/home/runner/work/react-json-view/react-json-view/test/tests/js/components/ArrayGroup-test.js:99:31)
      at processImmediate (node:internal/timers:483:21)

This error happens because of a broken pear dependancy of enzyme.
Enzyme imports "cheerio" package and uses a default export 👉 here
But cheerio doesn't have any default export anymore 👉 here

The solution - update the enzyme version.

However, after the update we receive an another error. Enzyme imports some internal code from cheerio and it breaks the build.
The fix is to use a RC version of cheerio. Details - cheeriojs/cheerio#2547

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-json-view	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 22, 2024 3:35pm

[Kikobeats]

@VadimZvf thanks for pushing this! I tried to update cheerio but tests are still failing, any idea why?

[VadimZvf]

@VadimZvf thanks for pushing this! I tried to update cheerio but tests are still failing, any idea why?

Oops... We should use exact version "~1.0.0-rc.3" → "1.0.0-rc.3"

Deps with "~1.0.0-rc.3"

npm list cheerio
@microlink/[email protected] /react-json-view
├── [email protected]
└─┬ [email protected]
  └── [email protected] deduped

With exact version "1.0.0-rc.3"

npm list cheerio
@microlink/[email protected] /react-json-view
├── [email protected]
└─┬ [email protected]
  └── [email protected] deduped

[VadimZvf]

Also we should put it into devDependencies 😬

[Kikobeats]

You fixed 🙌

[yehor-anisimov]

@VadimZvf Good job with locking "cheerio": "1.0.0-rc.3". It helped me on other project.