Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter tests relying on live internet connections #194

Merged
merged 1 commit into from
Aug 23, 2018

Conversation

Zegnat
Copy link
Member

@Zegnat Zegnat commented Aug 8, 2018

Following the convention set by Guzzle by introducing a test group “internet”. Did this for selfish reasons, as depending on the day, my testing will just kinda hang on these. Now those tests can easily be skipped: ./vendor/bin/phpunit --exclude-group internet.

You may not always have a live internet connection available during
testing. By moving all tests that require a live connection into a
specific group, they can easily be toggled with `--exclude-group`.

The group name “internet” reflects the one used by Guzzle:
https://guzzle3.readthedocs.io/testing/unit-testing.html#group-internet-annotation
Copy link
Member

@gRegorLove gRegorLove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aaronpk aaronpk merged commit 6e2688f into microformats:master Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants