Stop adding whitespace in html that is not in the source document #165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be an under-documented feature of
DOMDocument::saveHTML
. It may sometimes add a\n
at the end of its output. So when you just concatenate the string outputs of this method you may be introducing line breaks that weren’t in the original source.I think adding a
trim
of some sort is wrong, as you might then also be trimming Text nodes that actually should contain the line break.Instead what I have found to fix this is to move all the nodes into a
DocumentFragment
and retrieving the HTML of this fragment in one go.Prior to this fix, the parser returns the following, note the
\n
in["properties"]["content"][0]["html"]
: