Merge pull request #90 from gRegorLove/issue89

Added failing test and fix for #89.
microformats · Apr 17, 2016 · 0762d6b · 0762d6b
2 parents d653341 + 7a4357a
commit 0762d6b
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 4 deletions.
diff --git a/Mf2/Parser.php b/Mf2/Parser.php
@@ -409,14 +409,14 @@ public function innerText($el, $implied=false) {
 			if (in_array(strtolower($el->tagName), $excludeTags)) {
 				return $out;
 			} else if ($el->tagName == 'img') {
-				if ($el->getAttribute('alt') !== '') {
+				if ($el->hasAttribute('alt')) {
 					return $el->getAttribute('alt');
-				} else if (!$implied && $el->getAttribute('src') !== '') {
+				} else if (!$implied && $el->hasAttribute('src')) {
 					return $this->resolveUrl($el->getAttribute('src'));
 				}
-			} else if ($el->tagName == 'area' and $el->getAttribute('alt') !== '') {
+			} else if ($el->tagName == 'area' and $el->hasAttribute('alt')) {
 				return $el->getAttribute('alt');
-			} else if ($el->tagName == 'abbr' and $el->getAttribute('title') !== '') {
+			} else if ($el->tagName == 'abbr' and $el->hasAttribute('title')) {
 				return $el->getAttribute('title');
 			}
 		}

diff --git a/tests/Mf2/ParsePTest.php b/tests/Mf2/ParsePTest.php
@@ -115,4 +115,15 @@ public function testBrWhitespaceIssue69() {
 		$this->assertEquals('Street Name 9' . "\n" . '12345 NY, USA', $result['items'][0]['properties']['name'][0]);
 	}
 
+	/**
+	 * @see https://github.com/indieweb/php-mf2/issues/89
+	 */
+	public function testEmptyAlt() {
+		$input = '<div class="p-author h-card"><a href="/" class="p-org p-name"><img class="u-logo" src="/static/logo.jpg" alt="" />mention.tech</a></div>';
+		$result = Mf2\parse($input);
+
+		$this->assertEquals('mention.tech', $result['items'][0]['properties']['org'][0]);
+		$this->assertEquals('mention.tech', $result['items'][0]['properties']['name'][0]);
+	}
+
 }