Simulator embedding (very incomplete, behind flag) #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simulator is very incomplete and experimental. It's UI placement will certainly need work for smaller screens!
microbit-matt-hillsdon
changed the title
| )} | ||
| </Box> | ||
| {flags.simulator ? ( | ||
| <SplitView |
There was a problem hiding this comment.
This split view behaves poorly when nested like this (perhaps due to minimums).
The layout as a whole isn't consistent with the latest designs.
However, so long as it has no effect on the non-flagged layout I think it's worth merging so we can avoid maintaining a separate branch as we iterate on the simulator.
There was a problem hiding this comment.
Ah, I think it's the equivalent of this bug:
So we need to add an overlay element over the iframe (or for simplicity, each side) during the drag.
There was a problem hiding this comment.
Now I understand it I feel less bad about merging it. I'm going to leave this one to fix afterwards.
microbit-robert
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The simulator is deployed separately from https://github.com/microbit-foundation/micropython-microbit-v2-simulator
It is not ready for use and is being merged behind a flag to enable iterative development of the UI and simulator features.