Get the welcome video via the deployment rather than the CMS #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes more sense than using the CMS as it's not really content in the same way as everything else.
|
It looks like the alt text for the video (which was previously set in the CMS) wasn't previously meaningfully used, though the iframe had an English title. I've switched the iframe title to be translatable text and removed the hardcoded English. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes more sense than using the CMS as it's not really content in the same way as everything else.
Removes loading and error cases from the UI.
Motivated by #1148 as this isn't a bit of Sanity schema that makes any sense to extract.