Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation update from Crowdin #1139

Merged
merged 3 commits into from
Nov 13, 2023
Merged

Translation update from Crowdin #1139

merged 3 commits into from
Nov 13, 2023

Conversation

microbit-matt-hillsdon
Copy link
Collaborator

@microbit-matt-hillsdon microbit-matt-hillsdon commented Nov 12, 2023

Depends on review of

Copy link

Preview build will be at
https://review-python-editor-v3.microbit.org/translations/

@microbit-matt-hillsdon
Copy link
Collaborator Author

Just needs the UI testing when it rebuilds.

@microbit-matt-hillsdon microbit-matt-hillsdon marked this pull request as ready for review November 13, 2023 10:12
@microbit-matt-hillsdon
Copy link
Collaborator Author

Just needs the UI testing when it rebuilds.

Seems good!

@microbit-robert
Copy link
Collaborator

UI looks good. Minor comments on the related PRs - if no action is required then this is good to merge.

@microbit-matt-hillsdon
Copy link
Collaborator Author

UI looks good. Minor comments on the related PRs - if no action is required then this is good to merge.

Thanks - I've dealt with the feedback on those PRs and gone ahead and merged there and updated this PR. I'll merge this after reviewing the CI build.

@microbit-matt-hillsdon microbit-matt-hillsdon merged commit 638f3ee into main Nov 13, 2023
1 check passed
@microbit-matt-hillsdon microbit-matt-hillsdon deleted the translations branch November 13, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants