Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spi.read(-1) locks up MicroPython #208

Closed
microbit-carlos opened this issue May 2, 2024 · 1 comment
Closed

spi.read(-1) locks up MicroPython #208

microbit-carlos opened this issue May 2, 2024 · 1 comment
Labels
bug Something isn't working
Milestone
2.2.0-beta.1

Comments

@microbit-carlos
Copy link
Contributor

microbit-carlos commented May 2, 2024 •
edited
Loading

Without any devices connected to the SPI pins:

>>> spi.init()
>>> # This read() call never returns
>>> spi.read(-1)
@microbit-carlos microbit-carlos added the bug Something isn't working label May 2, 2024
@microbit-carlos microbit-carlos added this to the 2.2.0-beta.2 milestone May 2, 2024
dpgeorge added a commit that referenced this issue May 20, 2024
@dpgeorge
codal_port/microbit_spi: Raise ValueError if spi.read arg is negative.
ef2a57e 
Fixes issue #208.

Signed-off-by: Damien George <[email protected]>
@dpgeorge
Copy link
Collaborator

Fixed by ef2a57e, negative values now raise a ValueError.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
2.2.0-beta.1
Development

No branches or pull requests
2 participants
@dpgeorge @microbit-carlos