codal_port/microbit_microphone: Validate duration and rate args.

Signed-off-by: Damien George <[email protected]>
microbit-foundation · Apr 22, 2024 · c91ae4e · c91ae4e
1 parent 6465bba
commit c91ae4e
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/src/codal_port/microbit_microphone.c b/src/codal_port/microbit_microphone.c
@@ -184,6 +184,14 @@ static mp_obj_t microbit_microphone_record(mp_uint_t n_args, const mp_obj_t *pos
     mp_arg_val_t args[MP_ARRAY_SIZE(allowed_args)];
     mp_arg_parse_all(n_args - 1, pos_args + 1, kw_args, MP_ARRAY_SIZE(allowed_args), allowed_args, args);
 
+    // Validate arguments.
+    if (args[ARG_duration].u_int <= 0) {
+        mp_raise_ValueError(MP_ERROR_TEXT("duration out of bounds"));
+    }
+    if (args[ARG_rate].u_int <= 0) {
+        mp_raise_ValueError(MP_ERROR_TEXT("rate out of bounds"));
+    }
+
     // Create the AudioFrame to record into.
     size_t size = args[ARG_duration].u_int * args[ARG_rate].u_int / 1000;
     microbit_audio_frame_obj_t *audio_frame = microbit_audio_frame_make_new(size, args[ARG_rate].u_int);