Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail in a controlled way for asm_thumb use #82

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Conversation

microbit-matt-hillsdon
Copy link
Contributor

Closes #81

@netlify
Copy link

netlify bot commented Oct 10, 2022

Deploy Preview for distracted-dubinsky-fd8a42 ready!

Name Link
🔨 Latest commit f23ee24
🔍 Latest deploy log https://app.netlify.com/sites/distracted-dubinsky-fd8a42/deploys/63443e0e19da06000931d155
😎 Deploy Preview https://deploy-preview-82--distracted-dubinsky-fd8a42.netlify.app/demo
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@microbit-robert microbit-robert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Handles error in a controlled way.

@microbit-matt-hillsdon microbit-matt-hillsdon changed the title Fail in a controlled way for asm_thumb use. Fail in a controlled way for asm_thumb use Oct 10, 2022
@microbit-matt-hillsdon microbit-matt-hillsdon merged commit f266924 into main Oct 10, 2022
@microbit-matt-hillsdon microbit-matt-hillsdon deleted the asm-thumb branch October 10, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@micropython.asm_thumb code fails with an internal sim error
2 participants